Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update ALT+DEL/FORWARD_DEL behavior

Browse Source 
Old behavior
ALT+DEL: delete entire line
ALT+FORWARD_DEL: delete entire line

New behavior
ALT+DEL: delete characters after the cursor until line end offset.
ALT_FORWARD_DEL: delete characters before the cursor until line start offset.

Bug: 279723106
Test: atest android.text.method.cts.BaseKeyListenerTest
Change-Id: I725a929a224a2087b8809e5862d433ec113d67c0
This commit is contained in:
Seigo Nonaka
2023-04-27 11:27:07 +09:00
parent 41d88dd57b
commit 8edcadc04c
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
core/java/android/text/method/BaseKeyListener.java
View File

@@ -345,7 +345,7 @@ public abstract class BaseKeyListener extends MetaKeyKeyListener
}
// Alt+Backspace or Alt+ForwardDelete deletes the current line, if possible.
if (isAltActive && deleteLine(view, content)) {
if (isAltActive && deleteLineFromCursor(view, content, isForwardDelete)) {
return true;
}
@@ -438,18 +438,34 @@ public abstract class BaseKeyListener extends MetaKeyKeyListener
return false;
}
private boolean deleteLine(View view, Editable content) {
private boolean deleteLineFromCursor(View view, Editable content, boolean forward) {
if (view instanceof TextView) {
final int selectionStart = Selection.getSelectionStart(content);
final int selectionEnd = Selection.getSelectionEnd(content);
final int selectionMin;
final int selectionMax;
if (selectionStart < selectionEnd) {
selectionMin = selectionStart;
selectionMax = selectionEnd;
} else {
selectionMin = selectionEnd;
selectionMax = selectionStart;
}
final TextView textView = (TextView) view;
final Layout layout = textView.getLayout();
if (layout != null && !textView.isOffsetMappingAvailable()) {
final int line = layout.getLineForOffset(Selection.getSelectionStart(content));
final int start = layout.getLineStart(line);
final int end = layout.getLineEnd(line);
if (end != start) {
content.delete(start, end);
return true;
if (forward) {
content.delete(selectionMin, end);
} else {
content.delete(start, selectionMax);
}
return true;
}
}
return false;