Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes the wrong error logs for shortcut ranks (false alarm)

Browse Source 
Bug: 155443629
Test: Verify that all ShortcutManager tests pass the status check.
Change-Id: Iaac28b385782c82c03e44b937ca1871b40e30e94
This commit is contained in:
Mehdi Alizadeh
2020-04-30 17:51:37 -07:00
parent a1ad29da2d
commit 8e1ddd7d8c
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/core/java/com/android/server/pm/ShortcutPackage.java
View File

@@ -1444,10 +1444,6 @@ class ShortcutPackage extends ShortcutPackageItem {
// Don't adjust ranks for manifest shortcuts.
continue;
}
if (si.isCached() && !si.isDynamic()) {
// Don't adjust ranks for cached shortcuts that are not dynamic anymore.
continue;
}
// At this point, it must be dynamic.
if (!si.isDynamic()) {
s.wtf("Non-dynamic shortcut found.");
@@ -1984,7 +1980,7 @@ class ShortcutPackage extends ShortcutPackageItem {
dynamicList.removeIf((si) -> !si.isDynamic());
final ArrayList<ShortcutInfo> manifestList = new ArrayList<>(list);
dynamicList.removeIf((si) -> !si.isManifestShortcut());
manifestList.removeIf((si) -> !si.isManifestShortcut());
verifyRanksSequential(dynamicList);
verifyRanksSequential(manifestList);