Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't send PLUGIN_CHANGED broadcast unless something changed

Browse Source 
If a plugin changes the layout (e.g., CameraCutout changing status bar
height), the preference screen will call persistBoolean, which would
always cause PLUGIN_CHANGED to be broadcasted. This causes bad infinite
loops.

Test: install CameraCutout plugin and navigate to Settings > Sysui tuner
> Plugins and watch it loop a lot

Change-Id: Id340bbfb0864508f1895bbd1e6cb2849a839bad8
This commit is contained in:
Evan Laird
2017-11-09 15:53:01 -05:00
parent fde6ea8d29
commit 8ab04d4c84
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/SystemUI/src/com/android/systemui/tuner/PluginFragment.java
View File

@@ -169,16 +169,23 @@ public class PluginFragment extends PreferenceFragment {
protected boolean persistBoolean(boolean value) {
final int desiredState = value ? PackageManager.COMPONENT_ENABLED_STATE_ENABLED
: PackageManager.COMPONENT_ENABLED_STATE_DISABLED;
boolean shouldSendBroadcast = false;
for (int i = 0; i < mInfo.services.length; i++) {
ComponentName componentName = new ComponentName(mInfo.packageName,
mInfo.services[i].name);
mPm.setComponentEnabledSetting(componentName, desiredState,
PackageManager.DONT_KILL_APP);
if (mPm.getComponentEnabledSetting(componentName) != desiredState) {
mPm.setComponentEnabledSetting(componentName, desiredState,
PackageManager.DONT_KILL_APP);
shouldSendBroadcast = true;
}
}
if (shouldSendBroadcast) {
final String pkg = mInfo.packageName;
final Intent intent = new Intent(PluginManager.PLUGIN_CHANGED,
pkg != null ? Uri.fromParts("package", pkg, null) : null);
getContext().sendBroadcast(intent);
}
final String pkg = mInfo.packageName;
final Intent intent = new Intent(PluginManager.PLUGIN_CHANGED,
pkg != null ? Uri.fromParts("package", pkg, null) : null);
getContext().sendBroadcast(intent);
return true;
}