Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Ongoing Call] Remove TODOs that are no longer relevant.

Browse Source 
- system_gestures_start_threshold shouldn't ever change size.
- statusBarHeight does seem like the appropriate dimension to use to
determine the appropriate gesture area.

Bug: 195839150
Test: N/A (just removing code comments)
Change-Id: I1076d83120df0e1ea51d4e8d568a7a270cf35911
This commit is contained in:
Caitlin Cassidy
2021-10-13 18:24:48 +00:00
parent 4a90272461
commit 898cffe65c
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/SystemUI/src/com/android/systemui/statusbar/gesture/SwipeStatusBarAwayGestureHandler.kt
View File

@@ -53,7 +53,6 @@ open class SwipeStatusBarAwayGestureHandler @Inject constructor(
private var inputMonitor: InputMonitorCompat? = null
private var inputReceiver: InputChannelCompat.InputEventReceiver? = null
// TODO(b/195839150): Update this threshold when the config changes?
private var swipeDistanceThreshold: Int = context.resources.getDimensionPixelSize(
com.android.internal.R.dimen.system_gestures_start_threshold
)
@@ -84,8 +83,6 @@ open class SwipeStatusBarAwayGestureHandler @Inject constructor(
ACTION_DOWN -> {
if (
// Gesture starts just below the status bar
// TODO(b/195839150): Is [statusBarHeight] the correct dimension to use for
// determining which down touches are valid?
ev.y >= statusBarWindowController.statusBarHeight
&& ev.y <= 3 * statusBarWindowController.statusBarHeight
) {