Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Catch WindowManager exceptions so they don't crash the system.

Browse Source 
WindowManager throws an IllegalStateException when adding a view twice; this
should never happen (since show() and hide() are always called in the UIThread),
but when it does, it should not crash the system.

Test: existing CtsAutoFillServiceTestCases pass
Fixes: 62262781

Change-Id: Idfd246ff173f4abb606865b7ba8cc367eb6acaad
This commit is contained in:
Felipe Leme
2017-06-02 14:43:28 -07:00
parent 6d46bc2ed3
commit 876377d0b2
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
services/autofill/java/com/android/server/autofill/ui/FillUi.java
View File

@@ -398,6 +398,12 @@ final class FillUi {
} catch (WindowManager.BadTokenException e) {
if (sDebug) Slog.d(TAG, "Filed with with token " + params.token + " gone.");
mCallback.onDestroy();
} catch (IllegalStateException e) {
// WM throws an ISE if mContentView was added twice; this should never happen -
// since show() and hide() are always called in the UIThread - but when it does,
// it should not crash the system.
Slog.e(TAG, "Exception showing window " + params, e);
mCallback.onDestroy();
}
}
@@ -405,10 +411,18 @@ final class FillUi {
* Hides the window.
*/
void hide() {
if (mShowing) {
mContentView.setOnTouchListener(null);
mWm.removeView(mContentView);
mShowing = false;
try {
if (mShowing) {
mContentView.setOnTouchListener(null);
mWm.removeView(mContentView);
mShowing = false;
}
} catch (IllegalStateException e) {
// WM might thrown an ISE when removing the mContentView; this should never
// happen - since show() and hide() are always called in the UIThread - but if it
// does, it should not crash the system.
Slog.e(TAG, "Exception hiding window ", e);
mCallback.onDestroy();
}
}