Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "InputManagerService: Do not remove input channel when disposing monitor"

Browse Source 
This reverts commit b3c3021841.

The bug in Looper was fixed in AOSP, so we can now undo the workaround.

Bug: 195020232
Bug: 189135695
Test: None
Change-Id: Icc831d9bf63b0695899f163b70d1ccfd81b772be
This commit is contained in:
Prabir Pradhan
2021-09-20 11:10:44 -07:00
parent 50c01b22e1
commit 874f00fd29
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
services/core/java/com/android/server/input/InputManagerService.java
View File

@@ -3230,7 +3230,7 @@ public class InputManagerService extends IInputManager.Stub
* Interface for the system to handle request from InputMonitors.
*/
private final class InputMonitorHost extends IInputMonitorHost.Stub {
private IBinder mToken;
private final IBinder mToken;
InputMonitorHost(IBinder token) {
mToken = token;
@@ -3238,23 +3238,12 @@ public class InputManagerService extends IInputManager.Stub
@Override
public void pilferPointers() {
if (mToken == null) {
throw new IllegalStateException(
"Illegal call to pilferPointers after InputMonitorHost is disposed.");
}
nativePilferPointers(mPtr, mToken);
}
@Override
public void dispose() {
// We do not remove the input monitor here by calling nativeRemoveInputChannel because
// it causes a race in InputDispatcher between the removal of the InputChannel through
// that call and the InputChannel#dispose call (which causes an FD hangup) from the
// client (b/189135695).
//
// NOTE: This means the client is responsible for properly closing the InputMonitor by
// disposing the InputChannel and all its duplicates.
mToken = null;
nativeRemoveInputChannel(mPtr, mToken);
}
}