Revert "Stop face auth when bouncerWillBeShown instead of bouncerFullyShown"
This reverts commit 00ec45f4ec.
Reason for revert: UX concerns that this might break existing unlock
behavior
Bug: 247966043
Test: N/A
Change-Id: I91dd1a5a11c6d97293c974621c8797c36ff84a0b
This commit is contained in:
@@ -52,7 +52,6 @@ data class KeyguardFaceListenModel(
|
||||
val becauseCannotSkipBouncer: Boolean,
|
||||
val biometricSettingEnabledForUser: Boolean,
|
||||
val bouncerFullyShown: Boolean,
|
||||
val bouncerIsOrWillShow: Boolean,
|
||||
val faceAuthenticated: Boolean,
|
||||
val faceDisabled: Boolean,
|
||||
val faceLockedOut: Boolean,
|
||||
|
||||
@@ -2597,7 +2597,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab
|
||||
// on bouncer if both fp and fingerprint are enrolled.
|
||||
final boolean awakeKeyguardExcludingBouncerShowing = mKeyguardIsVisible
|
||||
&& mDeviceInteractive && !mGoingToSleep
|
||||
&& !statusBarShadeLocked && !mBouncerIsOrWillBeShowing;
|
||||
&& !statusBarShadeLocked && !mBouncerFullyShown;
|
||||
final int user = getCurrentUser();
|
||||
final int strongAuth = mStrongAuthTracker.getStrongAuthForUser(user);
|
||||
final boolean isLockDown =
|
||||
@@ -2667,7 +2667,6 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab
|
||||
becauseCannotSkipBouncer,
|
||||
biometricEnabledForUser,
|
||||
mBouncerFullyShown,
|
||||
mBouncerIsOrWillBeShowing,
|
||||
faceAuthenticated,
|
||||
faceDisabledForUser,
|
||||
isFaceLockedOut(),
|
||||
@@ -3243,8 +3242,7 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener, Dumpab
|
||||
cb.onKeyguardBouncerStateChanged(mBouncerIsOrWillBeShowing);
|
||||
}
|
||||
}
|
||||
updateBiometricListeningState(BIOMETRIC_ACTION_UPDATE,
|
||||
FaceAuthUiEvent.FACE_AUTH_UPDATED_PRIMARY_BOUNCER_SHOWN_OR_WILL_BE_SHOWN);
|
||||
updateFingerprintListeningState(BIOMETRIC_ACTION_UPDATE);
|
||||
}
|
||||
|
||||
if (wasBouncerFullyShown != mBouncerFullyShown) {
|
||||
|
||||
@@ -86,7 +86,6 @@ private fun faceModel(user: Int) = KeyguardFaceListenModel(
|
||||
becauseCannotSkipBouncer = false,
|
||||
biometricSettingEnabledForUser = false,
|
||||
bouncerFullyShown = false,
|
||||
bouncerIsOrWillShow = false,
|
||||
onlyFaceEnrolled = false,
|
||||
faceAuthenticated = false,
|
||||
faceDisabled = false,
|
||||
|
||||
@@ -1554,7 +1554,7 @@ public class KeyguardUpdateMonitorTest extends SysuiTestCase {
|
||||
anyBoolean());
|
||||
CancellationSignal cancelSignal = mCancellationSignalCaptor.getValue();
|
||||
|
||||
bouncerWillBeVisibleSoon();
|
||||
bouncerFullyVisible();
|
||||
mTestableLooper.processAllMessages();
|
||||
|
||||
assertThat(cancelSignal.isCanceled()).isTrue();
|
||||
@@ -1752,11 +1752,6 @@ public class KeyguardUpdateMonitorTest extends SysuiTestCase {
|
||||
setKeyguardBouncerVisibility(true);
|
||||
}
|
||||
|
||||
private void bouncerWillBeVisibleSoon() {
|
||||
mKeyguardUpdateMonitor.sendKeyguardBouncerChanged(true, false);
|
||||
mTestableLooper.processAllMessages();
|
||||
}
|
||||
|
||||
private void setKeyguardBouncerVisibility(boolean isVisible) {
|
||||
mKeyguardUpdateMonitor.sendKeyguardBouncerChanged(isVisible, isVisible);
|
||||
mTestableLooper.processAllMessages();
|
||||
|
||||
Reference in New Issue
Block a user