Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show all KCMs if IME doesn't provide language tag information

Browse Source 
Test: atest KeyboardLayoutManagerTests
Bug: 279281653
Change-Id: Idce443602bfa844b59754f980f8fc0ec0b2b7e66
This commit is contained in:
Vaibhav Devmurari
2023-04-23 14:38:21 +00:00
parent 77ea277fc7
commit 81f10425e6
2 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/core/java/com/android/server/input/KeyboardLayoutManager.java
View File

@@ -1262,7 +1262,7 @@ final class KeyboardLayoutManager implements InputManager.InputDeviceListener {
private static boolean isLayoutCompatibleWithLanguageTag(KeyboardLayout layout,
@NonNull String languageTag) {
LocaleList layoutLocales = layout.getLocales();
if (layoutLocales.isEmpty()) {
if (layoutLocales.isEmpty() || TextUtils.isEmpty(languageTag)) {
// KCM file doesn't have an associated language tag. This can be from
// a 3rd party app so need to include it as a potential layout.
return true;

24
services/tests/servicestests/src/com/android/server/input/KeyboardLayoutManagerTests.kt
View File

@@ -633,6 +633,30 @@ class KeyboardLayoutManagerTests {
0,
keyboardLayouts.size
)
// If IME doesn't have a corresponding language tag, then should show all available
// layouts no matter the script code.
keyboardLayouts =
keyboardLayoutManager.getKeyboardLayoutListForInputDevice(
keyboardDevice.identifier, USER_ID, imeInfo, null
)
assertNotEquals(
"New UI: getKeyboardLayoutListForInputDevice API should return all layouts if" +
"language tag or subtype not provided",
0,
keyboardLayouts.size
)
assertTrue("New UI: getKeyboardLayoutListForInputDevice API should contain Latin " +
"layouts if language tag or subtype not provided",
containsLayout(keyboardLayouts, ENGLISH_US_LAYOUT_DESCRIPTOR)
)
assertTrue("New UI: getKeyboardLayoutListForInputDevice API should contain Cyrillic " +
"layouts if language tag or subtype not provided",
containsLayout(
keyboardLayouts,
createLayoutDescriptor("keyboard_layout_russian")
)
)
}
}