Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix/suppress startop google-explicit-constructor warnings

Browse Source 
* Add explicit to conversion constructors/operators

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: I9e7b929cfa65c68f4cdb4710c1c5c6760d56e4d5
This commit is contained in:
Chih-Hung Hsieh
2018-12-20 13:53:28 -08:00
parent bcf293c674
commit 81aff0fbab
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
startop/view_compiler/dex_builder.h
View File

@@ -73,7 +73,7 @@ class TypeDescriptor {
bool operator<(const TypeDescriptor& rhs) const { return descriptor_ < rhs.descriptor_; }
private:
TypeDescriptor(std::string descriptor) : descriptor_{descriptor} {}
explicit TypeDescriptor(std::string descriptor) : descriptor_{descriptor} {}
const std::string descriptor_;
};
@@ -83,7 +83,7 @@ class TypeDescriptor {
class Prototype {
public:
template <typename... TypeDescriptors>
Prototype(TypeDescriptor return_type, TypeDescriptors... param_types)
explicit Prototype(TypeDescriptor return_type, TypeDescriptors... param_types)
: return_type_{return_type}, param_types_{param_types...} {}
// Encode this prototype into the dex file.

2
startop/view_compiler/main.cc
View File

@@ -42,7 +42,7 @@ DEFINE_string(package, "", "The package name for the generated class (required)"
class ViewCompilerXmlVisitor : public XMLVisitor {
public:
ViewCompilerXmlVisitor(JavaLangViewBuilder* builder) : builder_(builder) {}
explicit ViewCompilerXmlVisitor(JavaLangViewBuilder* builder) : builder_(builder) {}
bool VisitEnter(const XMLDocument& /*doc*/) override {
builder_->Start();