Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE on calling Resources.getConfiguration()

Browse Source 
Root cause: To update the code paths without triggering onChanged().
Explanation:
  1. The mInstallArgs.mInstallFlags contains
     PackageManager.DONT_KILL_APP.
  2. The existing package settings is not null.
     a.k.a. ps1.getOldCodePaths() != null
  3. The call flow doesn't trigger ps1.setOldCodePaths(...)
  4. The settings memory has been updated. However, snapshot doesn't
     update to the clients of PackageManagerServices.

Reference: b/210884444#comment12
Reference: b/209805326#comment10

Test: presubmit

Bug: 210884444
Bug: 209805326
Change-Id: I8a52a65bdfaed0ab385ee21b0512efae54f92c30
This commit is contained in:
Felka Chang
2022-01-10 23:58:09 +08:00
parent cd88027c3e
commit 819ab25c2f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
services/core/java/com/android/server/pm/InstallPackageHelper.java
View File

@@ -1969,14 +1969,15 @@ final class InstallPackageHelper {
reconciledPkg.mPrepareResult.mExistingPackage.getPackageName());
if ((reconciledPkg.mInstallArgs.mInstallFlags & PackageManager.DONT_KILL_APP)
== 0) {
if (ps1.getOldCodePaths() == null) {
ps1.setOldCodePaths(new ArraySet<>());
Set<String> oldCodePaths = ps1.getOldCodePaths();
if (oldCodePaths == null) {
oldCodePaths = new ArraySet<>();
}
Collections.addAll(ps1.getOldCodePaths(), oldPackage.getBaseApkPath());
Collections.addAll(oldCodePaths, oldPackage.getBaseApkPath());
if (oldPackage.getSplitCodePaths() != null) {
Collections.addAll(ps1.getOldCodePaths(),
oldPackage.getSplitCodePaths());
Collections.addAll(oldCodePaths, oldPackage.getSplitCodePaths());
}
ps1.setOldCodePaths(oldCodePaths);
} else {
ps1.setOldCodePaths(null);
}