Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add system ui background handlers dispatch and delivery logging thresholds

Browse Source 
Those thresholds would help us to further investigate bugs like this
one. Looper#showSlowLog prints Slog.w when the threshold is met. This risk free change will help us investigate issues when something got stuck in the background thread.

I've also removed misleading `run` from `UserTrackerImpl` because those are kotlin run to change context, which doesn't change execution thread.

Bug: 281851220
Test: manual
Change-Id: I127ec03e15f76295484e34b0ff0f3e7ad9ac9b88
This commit is contained in:
Anton Potapov
2023-05-12 14:56:53 +01:00
parent 53c901a01c
commit 80db4505cd
2 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/SystemUI/src/com/android/systemui/settings/UserTrackerImpl.kt
View File

@@ -166,21 +166,19 @@ open class UserTrackerImpl internal constructor(
}
override fun onUserSwitching(newUserId: Int, reply: IRemoteCallback?) {
backgroundHandler.run {
handleUserSwitching(newUserId)
reply?.sendResult(null)
}
handleUserSwitching(newUserId)
reply?.sendResult(null)
}
override fun onUserSwitchComplete(newUserId: Int) {
backgroundHandler.run {
handleUserSwitchComplete(newUserId)
}
handleUserSwitchComplete(newUserId)
}
}, TAG)
}
@WorkerThread
protected open fun handleBeforeUserSwitching(newUserId: Int) {
Assert.isNotMainThread()
setUserIdInternal(newUserId)
}

22
packages/SystemUI/src/com/android/systemui/util/concurrency/SysUIConcurrencyModule.java
View File

@@ -29,18 +29,28 @@ import com.android.systemui.dagger.qualifiers.BroadcastRunning;
import com.android.systemui.dagger.qualifiers.LongRunning;
import com.android.systemui.dagger.qualifiers.Main;
import dagger.Module;
import dagger.Provides;
import java.util.concurrent.Executor;
import javax.inject.Named;
import dagger.Module;
import dagger.Provides;
/**
* Dagger Module for classes found within the concurrent package.
*/
@Module
public abstract class SysUIConcurrencyModule {
// Slow BG executor can potentially affect UI if UI is waiting for an updated state from this
// thread
private static final Long BG_SLOW_DISPATCH_THRESHOLD = 1000L;
private static final Long BG_SLOW_DELIVERY_THRESHOLD = 1000L;
private static final Long LONG_SLOW_DISPATCH_THRESHOLD = 2500L;
private static final Long LONG_SLOW_DELIVERY_THRESHOLD = 2500L;
private static final Long BROADCAST_SLOW_DISPATCH_THRESHOLD = 1000L;
private static final Long BROADCAST_SLOW_DELIVERY_THRESHOLD = 1000L;
/** Background Looper */
@Provides
@SysUISingleton
@@ -49,6 +59,8 @@ public abstract class SysUIConcurrencyModule {
HandlerThread thread = new HandlerThread("SysUiBg",
Process.THREAD_PRIORITY_BACKGROUND);
thread.start();
thread.getLooper().setSlowLogThresholdMs(BG_SLOW_DISPATCH_THRESHOLD,
BG_SLOW_DELIVERY_THRESHOLD);
return thread.getLooper();
}
@@ -60,6 +72,8 @@ public abstract class SysUIConcurrencyModule {
HandlerThread thread = new HandlerThread("BroadcastRunning",
Process.THREAD_PRIORITY_BACKGROUND);
thread.start();
thread.getLooper().setSlowLogThresholdMs(BROADCAST_SLOW_DISPATCH_THRESHOLD,
BROADCAST_SLOW_DELIVERY_THRESHOLD);
return thread.getLooper();
}
@@ -71,6 +85,8 @@ public abstract class SysUIConcurrencyModule {
HandlerThread thread = new HandlerThread("SysUiLng",
Process.THREAD_PRIORITY_BACKGROUND);
thread.start();
thread.getLooper().setSlowLogThresholdMs(LONG_SLOW_DISPATCH_THRESHOLD,
LONG_SLOW_DELIVERY_THRESHOLD);
return thread.getLooper();
}