Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "[SettingsProvider] @Readable annotation to restrict acce..."

Browse Source 
Revert "[cts] tests for settings readable fields"

Revert submission 13355582-settings_readable

Reason for revert: b/178340718 b/178329499 b/178234427
Reverted Changes:
Id1f133d52:[cts] tests for settings readable fields
I8a2733580:[SettingsProvider] @Readable annotation to restric...

Change-Id: Ia55e58106e49ba411603bbadd8d909e22516293e
This commit is contained in:
Todd Kennedy
2021-01-25 16:06:54 +00:00
committed by Songchun Fan
parent 8b1a4d8c25
commit 7fd1ba73f4
2 changed files with 265 additions and 1376 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1587
core/java/android/provider/Settings.java
View File

File diff suppressed because it is too large Load Diff

54
packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java
View File

@@ -297,24 +297,6 @@ public class SettingsProvider extends ContentProvider {
Settings.System.getCloneFromParentOnValueSettings(sSystemCloneFromParentOnDependency);
}
private static final Set<String> sAllSecureSettings = new ArraySet<>();
private static final Set<String> sReadableSecureSettings = new ArraySet<>();
static {
Settings.Secure.getPublicSettings(sAllSecureSettings, sReadableSecureSettings);
}
private static final Set<String> sAllSystemSettings = new ArraySet<>();
private static final Set<String> sReadableSystemSettings = new ArraySet<>();
static {
Settings.System.getPublicSettings(sAllSystemSettings, sReadableSystemSettings);
}
private static final Set<String> sAllGlobalSettings = new ArraySet<>();
private static final Set<String> sReadableGlobalSettings = new ArraySet<>();
static {
Settings.Global.getPublicSettings(sAllGlobalSettings, sReadableGlobalSettings);
}
private final Object mLock = new Object();
@GuardedBy("mLock")
@@ -1937,7 +1919,6 @@ public class SettingsProvider extends ContentProvider {
if (UserHandle.getAppId(Binder.getCallingUid()) < Process.FIRST_APPLICATION_UID) {
return;
}
checkReadableAnnotation(settingsType, settingName);
ApplicationInfo ai = getCallingApplicationInfoOrThrow();
if (!ai.isInstantApp()) {
return;
@@ -1951,41 +1932,6 @@ public class SettingsProvider extends ContentProvider {
}
}
/**
* Check if the target settings key is readable. Reject if the caller app is trying to access a
* settings key defined in the Settings.Secure, Settings.System or Settings.Global and is not
* annotated as @Readable.
* Notice that a key string that is not defined in any of the Settings.* classes will still be
* regarded as readable.
*/
private void checkReadableAnnotation(int settingsType, String settingName) {
final Set<String> allFields;
final Set<String> readableFields;
switch (settingsType) {
case SETTINGS_TYPE_GLOBAL:
allFields = sAllGlobalSettings;
readableFields = sReadableGlobalSettings;
break;
case SETTINGS_TYPE_SYSTEM:
allFields = sAllSystemSettings;
readableFields = sReadableSystemSettings;
break;
case SETTINGS_TYPE_SECURE:
allFields = sAllSecureSettings;
readableFields = sReadableSecureSettings;
break;
default:
throw new IllegalArgumentException("Invalid settings type: " + settingsType);
}
if (allFields.contains(settingName) && !readableFields.contains(settingName)) {
throw new SecurityException(
"Settings key: <" + settingName + "> is not readable. From S+, new public "
+ "settings keys need to be annotated with @Readable unless they are "
+ "annotated with @hide.");
}
}
private ApplicationInfo getCallingApplicationInfoOrThrow() {
// We always use the callingUid for this lookup. This means that if hypothetically an
// app was installed in user A with cross user and in user B as an Instant App