Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't attach pipeline to group expansion mgr.

Browse Source 
This is to avoid a bug where the group state is broken after a
notification is removed and then re-added (e.g. after being filtered by
zenmode), and ExpandableNotificationRow.areChildrenExpanded ends up out
of sync with ExpandableNotificationRow.isGroupExpanded.

Bug: 282865576
Test: tested manually that the bug doesn't happen anymore
Change-Id: Id3066a9269b9484a30f16bd43236b061b0b6aefe
This commit is contained in:
Ioana Alexandru
2023-07-20 14:07:28 +00:00
parent 7787c0536e
commit 7f807071be
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/StackCoordinator.kt
View File

@@ -39,7 +39,10 @@ class StackCoordinator @Inject internal constructor(
override fun attach(pipeline: NotifPipeline) {
pipeline.addOnAfterRenderListListener(::onAfterRenderList)
groupExpansionManagerImpl.attach(pipeline)
// TODO(b/282865576): This has an issue where it makes changes to some groups without
// notifying listeners. To be fixed in QPR, but for now let's comment it out to avoid the
// group expansion bug.
// groupExpansionManagerImpl.attach(pipeline)
}
fun onAfterRenderList(entries: List<ListEntry>, controller: NotifStackController) =