Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Actually check for READ_PHONE_STATE permission for Voicemail query

Browse Source 
We were not checking READ_PHONE_STATE permission when callers
were querying for the number of voicemails the user had for a
subscription.

Removes old ITelephony#getVoiceMessageCount method from graylist
because it hasn't been used since kitkat and does not allow for
READ_PHONE_STATE permission checks.

Bug: 119884553
Test: manual
Change-Id: Ic6c29b123e192caf663d0e0c8da559116d1a78c9
This commit is contained in:
Brad Ebinger
2018-11-29 12:41:34 -08:00
parent 818a6e70e2
commit 7d0dbe6954
3 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
config/hiddenapi-light-greylist.txt
View File

@@ -3209,7 +3209,6 @@ Lcom/android/internal/telephony/ITelephony;->getCallState()I
Lcom/android/internal/telephony/ITelephony;->getDataActivity()I
Lcom/android/internal/telephony/ITelephony;->getDataState()I
Lcom/android/internal/telephony/ITelephony;->getNetworkType()I
Lcom/android/internal/telephony/ITelephony;->getVoiceMessageCount()I
Lcom/android/internal/telephony/ITelephony;->handlePinMmi(Ljava/lang/String;)Z
Lcom/android/internal/telephony/ITelephony;->handlePinMmiForSubscriber(ILjava/lang/String;)Z
Lcom/android/internal/telephony/ITelephony;->hasIccCard()Z

5
telephony/java/android/telephony/TelephonyManager.java
View File

@@ -4192,7 +4192,8 @@ public class TelephonyManager {
}
/**
* Returns the voice mail count for a subscription. Return 0 if unavailable.
* Returns the voice mail count for a subscription. Return 0 if unavailable or the caller does
* not have the READ_PHONE_STATE permission.
* @param subId whose voice message count is returned
* @hide
*/
@@ -4203,7 +4204,7 @@ public class TelephonyManager {
ITelephony telephony = getITelephony();
if (telephony == null)
return 0;
return telephony.getVoiceMessageCountForSubscriber(subId);
return telephony.getVoiceMessageCountForSubscriber(subId, getOpPackageName());
} catch (RemoteException ex) {
return 0;
} catch (NullPointerException ex) {

7
telephony/java/com/android/internal/telephony/ITelephony.aidl
View File

@@ -392,17 +392,12 @@ interface ITelephony {
*/
int getDataActivationState(int subId, String callingPackage);
/**
* Returns the unread count of voicemails
*/
int getVoiceMessageCount();
/**
* Returns the unread count of voicemails for a subId.
* @param subId user preferred subId.
* Returns the unread count of voicemails
*/
int getVoiceMessageCountForSubscriber(int subId);
int getVoiceMessageCountForSubscriber(int subId, String callingPackage);
/**
* Returns true if current state supports both voice and data