Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Create HintSessionWrapper in RT right after CanvasContext

Browse Source 
Move the construction of the HintSessionWrapper to RT right after the
creation of the CanvasContext to ensure enough time is provided to
not block the critical path in most cases.

Bug: 263755904
Test: manual
Change-Id: Ibab98b811de9056c51092286398d5c41c4d1d86b
Merged-In: I1a67b163acd9c41156d9b9e14e974c67b6ba6ed5
This commit is contained in:
Matt Buckley
2023-01-30 23:36:56 +00:00
parent 4514e31ec2
commit 7c1786beff
3 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/hwui/renderthread/DrawFrameTask.cpp
View File

@@ -278,6 +278,11 @@ void DrawFrameTask::unblockUiThread() {
mSignal.signal();
}
void DrawFrameTask::createHintSession(pid_t uiThreadId, pid_t renderThreadId) {
if (mHintSessionWrapper) return;
mHintSessionWrapper.emplace(uiThreadId, renderThreadId);
}
DrawFrameTask::HintSessionWrapper::HintSessionWrapper(int32_t uiThreadId, int32_t renderThreadId) {
if (!Properties::useHintManager) return;
if (uiThreadId < 0 || renderThreadId < 0) return;

2
libs/hwui/renderthread/DrawFrameTask.h
View File

@@ -90,6 +90,8 @@ public:
void forceDrawNextFrame() { mForceDrawFrame = true; }
void createHintSession(pid_t uiThreadId, pid_t renderThreadId);
private:
class HintSessionWrapper {
public:

15
libs/hwui/renderthread/RenderProxy.cpp
View File

@@ -38,11 +38,18 @@ namespace renderthread {
RenderProxy::RenderProxy(bool translucent, RenderNode* rootRenderNode,
IContextFactory* contextFactory)
: mRenderThread(RenderThread::getInstance()), mContext(nullptr) {
mContext = mRenderThread.queue().runSync([&]() -> CanvasContext* {
return CanvasContext::create(mRenderThread, translucent, rootRenderNode, contextFactory);
pid_t uiThreadId = pthread_gettid_np(pthread_self());
pid_t renderThreadId = getRenderThreadTid();
mContext = mRenderThread.queue().runSync([=, this]() -> CanvasContext* {
CanvasContext* context =
CanvasContext::create(mRenderThread, translucent, rootRenderNode, contextFactory);
if (context != nullptr) {
mRenderThread.queue().post(
[=] { mDrawFrameTask.createHintSession(uiThreadId, renderThreadId); });
}
return context;
});
mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode,
pthread_gettid_np(pthread_self()), getRenderThreadTid());
mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode, uiThreadId, renderThreadId);
}
RenderProxy::~RenderProxy() {