Revert "Revert "DO NOT MERGE Fix extraneous allocation and copying""

This reverts commit af60e56b39.

Change-Id: I1aa698608773b9e540457831e11218f371c71268
This commit is contained in:
Alan Lau
2014-07-30 17:35:29 +00:00
parent af60e56b39
commit 7ab1900a5a

View File

@@ -63,7 +63,7 @@ static jintArray nLineBreakOpportunities(JNIEnv* env, jclass, jstring javaLocale
jcharArray inputText, jint length,
jintArray recycle) {
jintArray ret;
std::vector<jint> breaks(16);
std::vector<jint> breaks;
ScopedIcuLocale icuLocale(env, javaLocaleName);
if (icuLocale.valid()) {
@@ -84,7 +84,7 @@ static jintArray nLineBreakOpportunities(JNIEnv* env, jclass, jstring javaLocale
breaks.push_back(-1); // sentinel terminal value
if (recycle != NULL && env->GetArrayLength(recycle) >= breaks.size()) {
if (recycle != NULL && static_cast<size_t>(env->GetArrayLength(recycle)) >= breaks.size()) {
ret = recycle;
} else {
ret = env->NewIntArray(breaks.size());