Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Use log.wtf on debug devices if property cannot be set" into pi-dev

Browse Source
This commit is contained in:
Fyodor Kupolov
2018-04-24 17:37:31 +00:00
committed by Android (Google) Code Review
parent 853af140f9 eb55fb60c0
commit 76372003a6
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
services/core/java/com/android/server/am/GlobalSettingsToPropertiesMapper.java
View File

@@ -19,6 +19,7 @@ package com.android.server.am;
import android.content.ContentResolver;
import android.database.ContentObserver;
import android.net.Uri;
import android.os.Build;
import android.os.SystemProperties;
import android.provider.Settings;
import android.text.TextUtils;
@@ -98,7 +99,14 @@ class GlobalSettingsToPropertiesMapper {
try {
systemPropertiesSet(key, value);
} catch (Exception e) {
Slog.e(TAG, "Unable to set property " + key + " value '" + value + "'", e);
// Failure to set a property can be caused by SELinux denial. This usually indicates
// that the property wasn't whitelisted in sepolicy.
// No need to report it on all user devices, only on debug builds.
if (Build.IS_DEBUGGABLE) {
Slog.wtf(TAG, "Unable to set property " + key + " value '" + value + "'", e);
} else {
Slog.e(TAG, "Unable to set property " + key + " value '" + value + "'", e);
}
}
}