Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Finalizing V2 Bugs - Removing TODOs" into udc-dev

Browse Source
This commit is contained in:
Arpan Kaphle
2023-03-06 19:28:30 +00:00
committed by Android (Google) Code Review
parent 5b1b82c3f2 becd35d55a
commit 761cab9a71
3 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/credentials/java/com/android/server/credentials/ClearRequestSession.java
View File

@@ -119,7 +119,6 @@ public final class ClearRequestSession extends RequestSession<ClearCredentialSta
private void respondToClientWithResponseAndFinish() {
Log.i(TAG, "respondToClientWithResponseAndFinish");
if (isSessionCancelled()) {
// TODO: Differentiate btw cancelled and false
mChosenProviderMetric.setChosenProviderStatus(
MetricUtilities.METRICS_PROVIDER_STATUS_FINAL_SUCCESS);
logApiCall(ApiName.CLEAR_CREDENTIAL, /* apiStatus */
@@ -144,7 +143,6 @@ public final class ClearRequestSession extends RequestSession<ClearCredentialSta
private void respondToClientWithErrorAndFinish(String errorType, String errorMsg) {
Log.i(TAG, "respondToClientWithErrorAndFinish");
if (isSessionCancelled()) {
// TODO: Differentiate btw cancelled and false
logApiCall(ApiName.CLEAR_CREDENTIAL, /* apiStatus */
ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);
finishSession(/*propagateCancellation=*/true);

2
services/credentials/java/com/android/server/credentials/CreateRequestSession.java
View File

@@ -143,7 +143,6 @@ public final class CreateRequestSession extends RequestSession<CreateCredentialR
return;
}
if (isSessionCancelled()) {
// TODO: Differentiate btw cancelled and false
logApiCall(ApiName.CREATE_CREDENTIAL, /* apiStatus */
ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);
finishSession(/*propagateCancellation=*/true);
@@ -168,7 +167,6 @@ public final class CreateRequestSession extends RequestSession<CreateCredentialR
return;
}
if (isSessionCancelled()) {
// TODO: Differentiate btw cancelled and false
logApiCall(ApiName.CREATE_CREDENTIAL, /* apiStatus */
ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);
finishSession(/*propagateCancellation=*/true);

1
services/credentials/java/com/android/server/credentials/GetRequestSession.java
View File

@@ -119,7 +119,6 @@ public final class GetRequestSession extends RequestSession<GetCredentialRequest
return;
}
if (isSessionCancelled()) {
// TODO: Differentiate btw cancelled and false
logApiCall(ApiName.GET_CREDENTIAL, /* apiStatus */
ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);
finishSession(/*propagateCancellation=*/true);