Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Make IInputMethodPrivilegedOperations to async (3/N)" into sc-dev

Browse Source
This commit is contained in:
Wilson Wu
2021-04-22 04:50:11 +00:00
committed by Android (Google) Code Review
parent 755cd83f49 c84b3e15df
commit 75f46d33c8
4 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/inputmethodservice/InputMethodService.java
View File

@@ -1627,7 +1627,7 @@ public class InputMethodService extends AbstractInputMethodService {
}
private void reportFullscreenMode() {
mPrivOps.reportFullscreenMode(mIsFullscreen);
mPrivOps.reportFullscreenModeAsync(mIsFullscreen);
}
/**

2
core/java/com/android/internal/inputmethod/IInputMethodPrivilegedOperations.aidl
View File

@@ -33,7 +33,7 @@ oneway interface IInputMethodPrivilegedOperations {
void reportStartInputAsync(in IBinder startInputToken);
void createInputContentUriToken(in Uri contentUri, in String packageName,
in IIInputContentUriTokenResultCallback resultCallback);
void reportFullscreenMode(boolean fullscreen, in IVoidResultCallback resultCallback);
void reportFullscreenModeAsync(boolean fullscreen);
void setInputMethod(String id, in IVoidResultCallback resultCallback);
void setInputMethodAndSubtype(String id, in InputMethodSubtype subtype,
in IVoidResultCallback resultCallback);

9
core/java/com/android/internal/inputmethod/InputMethodPrivilegedOperations.java
View File

@@ -169,21 +169,18 @@ public final class InputMethodPrivilegedOperations {
}
/**
* Calls {@link IInputMethodPrivilegedOperations#reportFullscreenMode(boolean,
* IVoidResultCallback)}.
* Calls {@link IInputMethodPrivilegedOperations#reportFullscreenModeAsync(boolean)}.
*
* @param fullscreen {@code true} if the IME enters full screen mode
*/
@AnyThread
public void reportFullscreenMode(boolean fullscreen) {
public void reportFullscreenModeAsync(boolean fullscreen) {
final IInputMethodPrivilegedOperations ops = mOps.getAndWarnIfNull();
if (ops == null) {
return;
}
try {
final Completable.Void value = Completable.createVoid();
ops.reportFullscreenMode(fullscreen, ResultCallbacks.of(value));
Completable.getResult(value);
ops.reportFullscreenModeAsync(fullscreen);
} catch (RemoteException e) {
throw e.rethrowFromSystemServer();
}

5
services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
View File

@@ -6006,9 +6006,8 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
@BinderThread
@Override
public void reportFullscreenMode(boolean fullscreen, IVoidResultCallback resultCallback) {
CallbackUtils.onResult(resultCallback,
() -> mImms.reportFullscreenMode(mToken, fullscreen));
public void reportFullscreenModeAsync(boolean fullscreen) {
mImms.reportFullscreenMode(mToken, fullscreen);
}
@BinderThread