Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor requestRefreshConfiguration call

Browse Source 
Currently, it appears that requestRefreshConfiguration can only ever be
called with a single configuration value. That means, we can probably
switch to using an enum class for the different configuration values,
and simplify some of the existing logic.

But it's not super obvious from code that only 1 bit is set in this
"changes" variable. Refactor it a little to make it more obvious.

Bug: 137212522
Test: none
Change-Id: I8d21e7ea05e0271229f72354888b722dfdaf3929
This commit is contained in:
Siarhei Vishniakou
2019-07-10 15:38:05 -07:00
parent c513c7036d
commit 7507d7bc02
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
services/core/jni/com_android_server_input_InputManagerService.cpp
View File

@@ -826,18 +826,19 @@ void NativeInputManager::setInputWindows(JNIEnv* env, jobjectArray windowHandleO
}
}
uint32_t changes = 0;
bool pointerGesturesEnabledChanged = false;
{ // acquire lock
AutoMutex _l(mLock);
if (mLocked.pointerGesturesEnabled != newPointerGesturesEnabled) {
mLocked.pointerGesturesEnabled = newPointerGesturesEnabled;
changes |= InputReaderConfiguration::CHANGE_POINTER_GESTURE_ENABLEMENT;
pointerGesturesEnabledChanged = true;
}
} // release lock
if (changes) {
mInputManager->getReader()->requestRefreshConfiguration(changes);
if (pointerGesturesEnabledChanged) {
mInputManager->getReader()->requestRefreshConfiguration(
InputReaderConfiguration::CHANGE_POINTER_GESTURE_ENABLEMENT);
}
}