Fix dismiss callback when keyguard is dismissing.

AnimatingAway is set to false before hide is called, causing the dismiss
action to be cancelled. This is breaking CarSysUI. Maintain parity with
the legacy bouncer by setting disppear animation to null when we hide
the bouncer so we maintain the state of animating away when we check to
see if we should dismiss the callback.

Fixes: 271166101
Test: Atest
Change-Id: Ia51ec982dd78b69db82f69ae525e402bd461f294
Merged-In: Ia51ec982dd78b69db82f69ae525e402bd461f294
This commit is contained in:
Aaron Liu
2023-03-27 11:29:54 -07:00
parent 2b671a036c
commit 74f6dce985
2 changed files with 7 additions and 9 deletions

View File

@@ -106,10 +106,9 @@ constructor(
val panelExpansionAmount: Flow<Float> = repository.panelExpansionAmount
/** 0f = bouncer fully hidden. 1f = bouncer fully visible. */
val bouncerExpansion: Flow<Float> =
combine(
repository.panelExpansionAmount,
repository.primaryBouncerShow
) { panelExpansion, primaryBouncerIsShowing ->
combine(repository.panelExpansionAmount, repository.primaryBouncerShow) {
panelExpansion,
primaryBouncerIsShowing ->
if (primaryBouncerIsShowing) {
1f - panelExpansion
} else {
@@ -201,6 +200,7 @@ constructor(
dismissCallbackRegistry.notifyDismissCancelled()
}
repository.setPrimaryStartDisappearAnimation(null)
falsingCollector.onBouncerHidden()
keyguardStateController.notifyPrimaryBouncerShowing(false /* showing */)
cancelShowRunnable()
@@ -312,11 +312,8 @@ constructor(
runnable.run()
return
}
val finishRunnable = Runnable {
runnable.run()
repository.setPrimaryStartDisappearAnimation(null)
}
repository.setPrimaryStartDisappearAnimation(finishRunnable)
repository.setPrimaryStartDisappearAnimation(runnable)
}
/** Determine whether to show the side fps animation. */

View File

@@ -131,6 +131,7 @@ class PrimaryBouncerInteractorTest : SysuiTestCase() {
verify(repository).setPrimaryShowingSoon(false)
verify(repository).setPrimaryShow(false)
verify(mPrimaryBouncerCallbackInteractor).dispatchVisibilityChanged(View.INVISIBLE)
verify(repository).setPrimaryStartDisappearAnimation(null)
}
@Test