Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix FragmentManager.FragmentLifecycleCallbacks scope

Browse Source 
Static class is much more useful here.

Bug: 32938039
Test: n/a
Change-Id: I0010fde25e3b2a4f59b360c0035505c831c07c53
This commit is contained in:
Adam Powell
2016-11-16 16:20:45 -08:00
parent e05713d93b
commit 74827260a8
5 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/current.txt
View File

@@ -4658,7 +4658,7 @@ package android.app {
method public abstract java.lang.String getName();
}
public abstract class FragmentManager.FragmentLifecycleCallbacks {
public static abstract class FragmentManager.FragmentLifecycleCallbacks {
ctor public FragmentManager.FragmentLifecycleCallbacks();
method public void onFragmentActivityCreated(android.app.FragmentManager, android.app.Fragment, android.os.Bundle);
method public void onFragmentAttached(android.app.FragmentManager, android.app.Fragment, android.content.Context);

2
api/system-current.txt
View File

@@ -4811,7 +4811,7 @@ package android.app {
method public abstract java.lang.String getName();
}
public abstract class FragmentManager.FragmentLifecycleCallbacks {
public static abstract class FragmentManager.FragmentLifecycleCallbacks {
ctor public FragmentManager.FragmentLifecycleCallbacks();
method public void onFragmentActivityCreated(android.app.FragmentManager, android.app.Fragment, android.os.Bundle);
method public void onFragmentAttached(android.app.FragmentManager, android.app.Fragment, android.content.Context);

2
api/test-current.txt
View File

@@ -4668,7 +4668,7 @@ package android.app {
method public abstract java.lang.String getName();
}
public abstract class FragmentManager.FragmentLifecycleCallbacks {
public static abstract class FragmentManager.FragmentLifecycleCallbacks {
ctor public FragmentManager.FragmentLifecycleCallbacks();
method public void onFragmentActivityCreated(android.app.FragmentManager, android.app.Fragment, android.os.Bundle);
method public void onFragmentAttached(android.app.FragmentManager, android.app.Fragment, android.content.Context);

2
core/java/android/app/FragmentManager.java
View File

@@ -387,7 +387,7 @@ public abstract class FragmentManager {
* Callback interface for listening to fragment state changes that happen
* within a given FragmentManager.
*/
public abstract class FragmentLifecycleCallbacks {
public abstract static class FragmentLifecycleCallbacks {
/**
* Called right before the fragment's {@link Fragment#onAttach(Context)} method is called.
* This is a good time to inject any required dependencies for the fragment before any of

3
packages/SystemUI/src/com/android/systemui/fragments/FragmentHostManager.java
View File

@@ -62,8 +62,7 @@ public class FragmentHostManager {
private void createFragmentHost(Parcelable savedState) {
mFragments = FragmentController.createController(new HostCallbacks());
mFragments.attachHost(null);
// TODO: Remove non-staticness from FragmentLifecycleCallbacks (hopefully).
mLifecycleCallbacks = mFragments.getFragmentManager().new FragmentLifecycleCallbacks() {
mLifecycleCallbacks = new FragmentLifecycleCallbacks() {
@Override
public void onFragmentViewCreated(FragmentManager fm, Fragment f, View v,
Bundle savedInstanceState) {