FileSource may fail to open a file in which case subsequent code dereferences a NULL pointer. This fixes this recently introduced problem.

Change-Id: I60dd9532b694a1b488743b71f43e107c778d6683
2010-10-27 10:33:04 -07:00
parent 81bd788ecf
commit 7459b018db
1 changed files with 1 additions and 1 deletions
--- a/media/libstagefright/FileSource.cpp
+++ b/media/libstagefright/FileSource.cpp
@@ -21,7 +21,7 @@ namespace android {

 FileSource::FileSource(const char *filename)
    : mFile(fopen(filename, "rb")),
-      mFd(fileno(mFile)),
+      mFd(mFile == NULL ? -1 : fileno(mFile)),
      mOffset(0),
      mLength(-1),
      mDecryptHandle(NULL),