Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove legacy check for reversed ZWJ emoji sequences.

Browse Source 
According to Behdad this issue was fixed in HarfBuzz 2.0.0, October
2018.

Change-Id: I6e23ae7d637f79cb55b99a73ac8d16a0b0395610

Bug: 158944323
Test: drew a ZWJ in RTL and it worked fine
(https://screenshot.googleplex.com/AHrRaKNR6S4Nwgb.png)

Change-Id: I29e64f4577c819dfec0f3cbd878f0241bf706de0
This commit is contained in:
Rod S
2021-12-23 16:19:54 -08:00
parent f1be3163f5
commit 7388cdfeb6
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/fonts/fontchain_linter.py
View File

@@ -635,23 +635,11 @@ def compute_expected_emoji():
sequence = tuple(ch for ch in sequence if ch != EMOJI_VS)
all_sequences.add(sequence)
sequence_pieces.update(sequence)
if _emoji_sequences.get(sequence, None) == 'Emoji_Tag_Sequence':
# Add reverse of all emoji ZWJ sequences, which are added to the
# fonts as a workaround to get the sequences work in RTL text.
# TODO: test if these are actually needed by Minikin/HarfBuzz.
reversed_seq = reverse_emoji(sequence)
all_sequences.add(reversed_seq)
equivalent_emoji[reversed_seq] = sequence
for sequence in adjusted_emoji_zwj_sequences.keys():
sequence = tuple(ch for ch in sequence if ch != EMOJI_VS)
all_sequences.add(sequence)
sequence_pieces.update(sequence)
# Add reverse of all emoji ZWJ sequences, which are added to the fonts
# as a workaround to get the sequences work in RTL text.
reversed_seq = reverse_emoji(sequence)
all_sequences.add(reversed_seq)
equivalent_emoji[reversed_seq] = sequence
for first, second in SAME_FLAG_MAPPINGS:
equivalent_emoji[first] = second