Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Restore the isModule check when enabling rollback for apps

Browse Source 
This is effectively a revert of ag/12874515.

Bug: 171852511
Test: atest RollbackTest StagedRollbackTest
Change-Id: I566ffe0417ed460006917e1f2e08981a7943c63b
This commit is contained in:
JW Wang
2020-10-28 15:22:44 +08:00
parent d00e7d7ce5
commit 737f6f7acf
1 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
services/core/java/com/android/server/rollback/RollbackManagerServiceImpl.java
View File

@@ -28,6 +28,7 @@ import android.content.Intent;
import android.content.IntentFilter;
import android.content.IntentSender;
import android.content.pm.ApplicationInfo;
import android.content.pm.ModuleInfo;
import android.content.pm.PackageInfo;
import android.content.pm.PackageInstaller;
import android.content.pm.PackageManager;
@@ -1088,8 +1089,8 @@ class RollbackManagerServiceImpl extends IRollbackManager.Stub implements Rollba
Manifest.permission.TEST_MANAGE_ROLLBACKS,
installerPackageName) == PackageManager.PERMISSION_GRANTED;
// For now only allow rollbacks for allowlisted packages or for testing.
return (isRollbackAllowlisted(packageName) && manageRollbacksGranted)
// For now only allow rollbacks for modules, allowlisted packages, or for testing.
return (isRollbackAllowed(packageName) && manageRollbacksGranted)
|| testManageRollbacksGranted;
}
@@ -1097,8 +1098,24 @@ class RollbackManagerServiceImpl extends IRollbackManager.Stub implements Rollba
* Returns true is this package is eligible for enabling rollback.
*/
@AnyThread
private boolean isRollbackAllowlisted(String packageName) {
return SystemConfig.getInstance().getRollbackWhitelistedPackages().contains(packageName);
private boolean isRollbackAllowed(String packageName) {
return SystemConfig.getInstance().getRollbackWhitelistedPackages().contains(packageName)
|| isModule(packageName);
}
/**
* Returns true if the package name is the name of a module.
*/
@AnyThread
private boolean isModule(String packageName) {
PackageManager pm = mContext.getPackageManager();
final ModuleInfo moduleInfo;
try {
moduleInfo = pm.getModuleInfo(packageName, 0);
} catch (PackageManager.NameNotFoundException e) {
return false;
}
return moduleInfo != null;
}
/**