Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ActivityManager] Fix race condition in pss collection

Browse Source 
Symptom:
There has a race condition that two threads are accessing
the mPendingPssProcesses simultaneously. One of the thread
is collecting the process pss by looping the mPendingPssProcesses.
The other thread is requesting to collect pss of all processes,
which clears mPendingPssProcesses and adding processes back.

Solution:
Avoid race condition by adding synchornized protection.

Change-Id: Ifb090eda9c4a1b8e3fd980fe0171e9dd77773b46
This commit is contained in:
louis_chang
2014-12-02 12:57:39 +08:00
committed by Craig Mautner
parent 932c332147
commit 71e737c8e8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/am/ActivityManagerService.java
View File

@@ -1669,7 +1669,9 @@ public final class ActivityManagerService extends ActivityManagerNative
break;
}
case REQUEST_ALL_PSS_MSG: {
requestPssAllProcsLocked(SystemClock.uptimeMillis(), true, false);
synchronized (ActivityManagerService.this) {
requestPssAllProcsLocked(SystemClock.uptimeMillis(), true, false);
}
break;
}
case START_PROFILES_MSG: {