Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup comments, see bug 2401350.

Browse Source 
Change-Id: Ieaeeba44b235038ad9b75a57b37658738532df3f
This commit is contained in:
Wink Saville
2010-02-01 15:42:52 -08:00
parent d615c6f330
commit 7188f94652
6 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
telephony/java/com/android/internal/telephony/Phone.java
View File

@@ -1399,11 +1399,6 @@ public interface Phone {
/* CDMA support methods */
/*
* TODO(Moto) TODO(Teleca): can getCdmaMin, getEsn, getMeid use more generic calls
* already defined getXxxx above?
*/
/**
* Retrieves the MIN for CDMA phones.
*/

7
telephony/java/com/android/internal/telephony/RIL.java
View File

@@ -2982,10 +2982,9 @@ public final class RIL extends BaseCommands implements CommandsInterface {
numServiceCategories = p.readInt();
if (numServiceCategories == 0) {
// TODO(Teleca) TODO(Moto): The logic of providing default
// values should not be done by this transport layer. And
// needs to be done by the vendor ril or application logic.
// TODO(Google): Remove ASAP
// TODO: The logic of providing default values should
// not be done by this transport layer. And needs to
// be done by the vendor ril or application logic.
int numInts;
numInts = CDMA_BROADCAST_SMS_NO_OF_SERVICE_CATEGORIES * CDMA_BSI_NO_OF_INTS_STRUCT + 1;
response = new int[numInts];

2
telephony/java/com/android/internal/telephony/cdma/CDMAPhone.java
View File

@@ -681,7 +681,7 @@ public class CDMAPhone extends PhoneBase {
public String getVoiceMailNumber() {
String number = null;
SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(getContext());
// TODO(Moto): The default value of voicemail number should be read from a system property
// TODO: The default value of voicemail number should be read from a system property
number = sp.getString(VM_NUMBER_CDMA, "*86");
return number;
}

2
telephony/java/com/android/internal/telephony/cdma/CdmaInformationRecords.java
View File

@@ -74,7 +74,7 @@ public final class CdmaInformationRecords {
break;
case RIL_CDMA_T53_RELEASE_INFO_REC:
// TODO(Moto): WHAT to do, for now fall through and throw exception
// TODO: WHAT to do, for now fall through and throw exception
default:
throw new RuntimeException("RIL_UNSOL_CDMA_INFO_REC: unsupported record. Got "
+ CdmaInformationRecords.idToString(id) + " ");

4
telephony/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java
View File

@@ -1622,9 +1622,7 @@ final class CdmaServiceStateTracker extends ServiceStateTracker {
* Returns IMSI as MCC + MNC + MIN
*/
String getImsi() {
// TODO(Moto): When RUIM is enabled, IMSI will come from RUIM
// not build-time props. Moto will provide implementation
// for RUIM-ready case later.
// TODO: When RUIM is enabled, IMSI will come from RUIM not build-time props.
String operatorNumeric = SystemProperties.get(
TelephonyProperties.PROPERTY_ICC_OPERATOR_NUMERIC, "");

2
telephony/java/com/android/internal/telephony/cdma/RuimRecords.java
View File

@@ -166,10 +166,8 @@ public final class RuimRecords extends IccRecords {
return null;
}
// TODO(Moto): mncLength is not set anywhere.
if (mncLength != UNINITIALIZED && mncLength != UNKNOWN) {
// Length = length of MCC + length of MNC
// TODO: change spec name
// length of mcc = 3 (3GPP2 C.S0005 - Section 2.3)
return mImsi.substring(0, 3 + mncLength);
}