Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Improving comment inside expandWithQs for special split shade case" into tm-dev

Browse Source
This commit is contained in:
Michał Brzeziński
2022-05-11 11:58:28 +00:00
committed by Android (Google) Code Review
parent 05aa78241d cd21376df0
commit 7144969d6b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelViewController.java
View File

@@ -1693,9 +1693,11 @@ public class NotificationPanelViewController extends PanelViewController {
if (mShouldUseSplitNotificationShade && isOnKeyguard()) { if (mShouldUseSplitNotificationShade && isOnKeyguard()) {
// It's a special case as this method is likely to not be initiated by finger movement // It's a special case as this method is likely to not be initiated by finger movement
// but rather called from adb shell or accessibility service. // but rather called from adb shell or accessibility service.
// In the future method below could be used for non-split shade as well but currently // We're using LockscreenShadeTransitionController because on lockscreen that's the
// motion in that case looks worse than using flingSettings. // source of truth for all shade motion. Not using it would make part of state to be
// TODO: make below function transitioning smoothly also in portrait with empty target // outdated and will cause bugs. Ideally we'd use this controller also for non-split
// case but currently motion in portrait looks worse than when using flingSettings.
// TODO: make below function transitioning smoothly also in portrait with null target
mLockscreenShadeTransitionController.goToLockedShade( mLockscreenShadeTransitionController.goToLockedShade(
/* expandedView= */null, /* needsQSAnimation= */false); /* expandedView= */null, /* needsQSAnimation= */false);
} else if (isFullyCollapsed()) { } else if (isFullyCollapsed()) {