Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am b20b0629: am 71dfc7e9: Merge "Memory leak in parsePackage"

Browse Source 
* commit 'b20b0629c2ea6a8e1f7bebd0791dd21e545a4605':
  Memory leak in parsePackage
This commit is contained in:
Narayan Kamath
2014-06-24 14:26:45 +00:00
committed by Android Git Automerger
parent ed8b77e668 b20b0629c2
commit 70bf06986a
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
libs/androidfw/ResourceTypes.cpp
View File

@@ -5408,23 +5408,33 @@ status_t ResTable::parsePackage(const ResTable_package* const pkg,
return (mError=err);
}
//printf("Adding new package id %d at index %d\n", id, idx);
err = mPackageGroups.add(group);
err = group->packages.add(package);
if (err < NO_ERROR) {
delete group;
delete package;
return (mError=err);
}
group->basePackage = package;
//printf("Adding new package id %d at index %d\n", id, idx);
err = mPackageGroups.add(group);
if (err < NO_ERROR) {
delete group;
return (mError=err);
}
mPackageMap[id] = (uint8_t)idx;
} else {
group = mPackageGroups.itemAt(idx-1);
if (group == NULL) {
delete package;
return (mError=UNKNOWN_ERROR);
}
}
err = group->packages.add(package);
if (err < NO_ERROR) {
return (mError=err);
err = group->packages.add(package);
if (err < NO_ERROR) {
delete package;
return (mError=err);
}
}
} else {
LOG_ALWAYS_FATAL("Package id out of range");