Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add comments to the arguments passed to FrameTracker

Browse Source 
Test: n/a
Change-Id: I2bca428d7a92006fb370a8608696b34b77a35941
This commit is contained in:
Marcin Oczeretko
2020-11-20 15:26:38 +00:00
parent 1aac4088f4
commit 7080b677a5
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/tests/coretests/src/com/android/internal/jank/FrameTrackerTest.java
View File

@@ -77,7 +77,8 @@ public class FrameTrackerTest {
Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);
mTracker = Mockito.spy(
new FrameTracker(session, handler, mRenderer, mWrapper, 1, -1));
new FrameTracker(session, handler, mRenderer, mWrapper,
/*traceThresholdMissedFrames=*/ 1, /*traceThresholdFrameTimeMillis=*/ -1));
doNothing().when(mTracker).triggerPerfetto();
}

6
core/tests/coretests/src/com/android/internal/jank/InteractionJankMonitorTest.java
View File

@@ -94,7 +94,8 @@ public class InteractionJankMonitorTest {
Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);
FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(),
new ThreadedRendererWrapper(mView.getThreadedRenderer()),
new FrameMetricsWrapper(), 1, -1));
new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1,
/*traceThresholdFrameTimeMillis=*/ -1));
doReturn(tracker).when(monitor).createFrameTracker(any());
// Simulate a trace session and see if begin / end are invoked.
@@ -150,7 +151,8 @@ public class InteractionJankMonitorTest {
Session session = new Session(CUJ_NOTIFICATION_SHADE_EXPAND_COLLAPSE);
FrameTracker tracker = spy(new FrameTracker(session, mWorker.getThreadHandler(),
new ThreadedRendererWrapper(mView.getThreadedRenderer()),
new FrameMetricsWrapper(), 1, -1));
new FrameMetricsWrapper(), /*traceThresholdMissedFrames=*/ 1,
/*traceThresholdFrameTimeMillis=*/ -1));
doReturn(tracker).when(monitor).createFrameTracker(any());
assertThat(monitor.begin(session.getCuj())).isTrue();