Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure to call SomeArgs#recycle() in IMMS#handleMessage

Browse Source 
This is a small follow up CL to our previous CL [1], which added a new
internal message MSG_INLINE_SUGGESTIONS_REQUEST and its handler that
rely on SomeArgs but forget to call SomeArgs#recycle().

Although not calling SomeArgs#recycle() doesn't immediately cause any
fatal issue, not doing so basically spoils the purpose of SomeArgs.
With this CL, InputMethodManagerService#handleMessage should call
SomeArgs#recycle() when necessary.

Other than that there is no behavior change.

 [1]: Id222500c373898d576661cacb7a1cb51061041d4
      bc67f2e158

Bug: 147037345
Test: atest CtsAutoFillServiceTestCases
Change-Id: I763bb78c7d1ada327abaa110d423309b17d831d8
This commit is contained in:
Yohei Yukawa
2020-05-14 18:14:24 -07:00
parent 8c211a713b
commit 6e9768e902
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/inputmethod/InputMethodManagerService.java
View File

@@ -4262,7 +4262,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
}
// ---------------------------------------------------------------
case MSG_INLINE_SUGGESTIONS_REQUEST:
case MSG_INLINE_SUGGESTIONS_REQUEST: {
args = (SomeArgs) msg.obj;
final InlineSuggestionsRequestInfo requestInfo =
(InlineSuggestionsRequestInfo) args.arg2;
@@ -4274,7 +4274,9 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
} catch (RemoteException e) {
Slog.w(TAG, "RemoteException calling onCreateInlineSuggestionsRequest(): " + e);
}
args.recycle();
return true;
}
}
return false;
}