Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't hide the mobile type id if it doesn't change

Browse Source 
_Someone_ thought it would be a good idea to hide the mobile type
indicator if it hadn't changed from the last state. Better to not do
that.

Also removed an unused method in StatusBarIconControllerImpl.

Test: Reboot device with wifi off; data type indicator should show up
eventually; i.e., visual
Fixes: 77581445

Change-Id: I47a0c868b0e332c11e206b8c043a532bcbf10130
This commit is contained in:
Evan Laird
2018-04-05 16:22:36 -04:00
parent 2edaf6244c
commit 6dedbe6a4d
3 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
View File

@@ -142,12 +142,14 @@ public class StatusBarMobileView extends AlphaOptimizedLinearLayout implements D
if (mState.strengthId != state.strengthId) {
mMobileDrawable.setLevel(state.strengthId);
}
if (mState.typeId != state.typeId && state.typeId != 0) {
mMobileType.setContentDescription(state.typeContentDescription);
mMobileType.setImageResource(state.typeId);
mMobileType.setVisibility(View.VISIBLE);
} else {
mMobileType.setVisibility(View.GONE);
if (mState.typeId != state.typeId) {
if (state.typeId != 0) {
mMobileType.setContentDescription(state.typeContentDescription);
mMobileType.setImageResource(state.typeId);
mMobileType.setVisibility(View.VISIBLE);
} else {
mMobileType.setVisibility(View.GONE);
}
}
mMobileRoaming.setVisibility(state.roaming ? View.VISIBLE : View.GONE);

11
packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarIconControllerImpl.java
View File

@@ -306,17 +306,6 @@ public class StatusBarIconControllerImpl extends StatusBarIconList implements Tu
mIconGroups.forEach(l -> l.onSetIconHolder(viewIndex, holder));
}
/**
* For mobile essentially (an array of holders in one slot)
*/
private void handleSet(int slotIndex, List<StatusBarIconHolder> holders) {
for (StatusBarIconHolder holder : holders) {
int viewIndex = getViewIndex(slotIndex, holder.getTag());
mIconLogger.onIconVisibility(getSlotName(slotIndex), holder.isVisible());
mIconGroups.forEach(l -> l.onSetIconHolder(viewIndex, holder));
}
}
@Override
public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
pw.println(TAG + " state:");

2
packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarSignalPolicy.java
View File

@@ -414,7 +414,7 @@ public class StatusBarSignalPolicy implements NetworkControllerImpl.SignalCallba
@Override public String toString() {
return "MobileIconState(subId=" + subId + ", strengthId=" + strengthId + ", roaming="
+ roaming + ", visible=" + visible + ")";
+ roaming + ", typeId=" + typeId + ", visible=" + visible + ")";
}
}
}