Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BulkCursorToCursorAdaptor.respond no longer assumes RemoteException is impossible, fails more gracefully.

Browse Source 
This fixes bug 1923131 which was crashing the system process in some cases when the search dialog
was calling respond on its cursor to GlobalSearch.
This commit is contained in:
Karl Rosaen
2009-06-22 12:51:35 -07:00
parent d6dd686bc7
commit 6dc0ef005d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/java/android/database/BulkCursorToCursorAdaptor.java
View File

@@ -247,9 +247,11 @@ public final class BulkCursorToCursorAdaptor extends AbstractWindowedCursor {
try {
return mBulkCursor.respond(extras);
} catch (RemoteException e) {
// This should never happen because the system kills processes that are using remote
// cursors when the provider process is killed.
throw new RuntimeException(e);
// the system kills processes that are using remote cursors when the provider process
// is killed, but this can still happen if this is being called from the system process,
// so, better to log and return an empty bundle.
Log.w(TAG, "respond() threw RemoteException, returning an empty bundle.", e);
return Bundle.EMPTY;
}
}
}