Detect integer overflow

See Change-Id: Iec36fc0ea67095e18a2c238b148dad5545c102c1 Change-Id: I421f0d84c64310fcb6c5451993cfaf38125c4bb2
2013-07-18 17:15:43 -07:00
parent 8057f24d4a
commit 6ab188589d
1 changed files with 2 additions and 0 deletions
--- a/media/java/android/media/AudioRecord.java
+++ b/media/java/android/media/AudioRecord.java
@@ -587,6 +587,7 @@ public class AudioRecord
        }

        if ( (audioData == null) || (offsetInBytes < 0 ) || (sizeInBytes < 0)
+                || (offsetInBytes + sizeInBytes < 0)  // detect integer overflow
                || (offsetInBytes + sizeInBytes > audioData.length)) {
            return ERROR_BAD_VALUE;
        }
@@ -611,6 +612,7 @@ public class AudioRecord
        }

        if ( (audioData == null) || (offsetInShorts < 0 ) || (sizeInShorts < 0)
+                || (offsetInShorts + sizeInShorts < 0)  // detect integer overflow
                || (offsetInShorts + sizeInShorts > audioData.length)) {
            return ERROR_BAD_VALUE;
        }