Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Syncronize frameowrk and ImsStack operation for ImsFeatureStatusCallback."

Browse Source
This commit is contained in:
Treehugger Robot
2022-11-08 17:07:54 +00:00
committed by Gerrit Code Review
parent 4d07687915 85b387b5a2
commit 691bfb642a
2 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
telephony/java/android/telephony/ims/ImsService.java
View File

@@ -425,8 +425,8 @@ public class ImsService extends Service {
}
}
private IImsRcsFeature createRcsFeatureInternal(int slotId, int subI) {
RcsFeature f = createRcsFeatureForSubscription(slotId, subI);
private IImsRcsFeature createRcsFeatureInternal(int slotId, int subId) {
RcsFeature f = createRcsFeatureForSubscription(slotId, subId);
if (f != null) {
f.setDefaultExecutor(mExecutor);
setupFeature(f, slotId, ImsFeature.FEATURE_RCS);

14
telephony/java/android/telephony/ims/feature/ImsFeature.java
View File

@@ -394,10 +394,12 @@ public abstract class ImsFeature {
@VisibleForTesting
public void addImsFeatureStatusCallback(@NonNull IImsFeatureStatusCallback c) {
try {
// If we have just connected, send queued status.
c.notifyImsFeatureStatus(getFeatureState());
// Add the callback if the callback completes successfully without a RemoteException.
mStatusCallbacks.register(c);
synchronized (mStatusCallbacks) {
// Add the callback if the callback completes successfully without a RemoteException
mStatusCallbacks.register(c);
// If we have just connected, send queued status.
c.notifyImsFeatureStatus(getFeatureState());
}
} catch (RemoteException e) {
Log.w(LOG_TAG, "Couldn't notify feature state: " + e.getMessage());
}
@@ -409,7 +411,9 @@ public abstract class ImsFeature {
*/
@VisibleForTesting
public void removeImsFeatureStatusCallback(@NonNull IImsFeatureStatusCallback c) {
mStatusCallbacks.unregister(c);
synchronized (mStatusCallbacks) {
mStatusCallbacks.unregister(c);
}
}
/**