Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Change SharedConnectivityService's permission check to use checkCallingOrSelfPermission" into udc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2023-02-24 19:12:44 +00:00
committed by Android (Google) Code Review
parent deb6c5c0ab 8d0547c39a
commit 68e79acf4a
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
wifi/java/src/android/net/wifi/sharedconnectivity/service/SharedConnectivityService.java
View File

@@ -130,10 +130,17 @@ public abstract class SharedConnectivityService extends Service {
@RequiresPermission(anyOf = {android.Manifest.permission.NETWORK_SETTINGS,
android.Manifest.permission.NETWORK_SETUP_WIZARD})
/**
* checkPermissions is using checkCallingOrSelfPermission to support CTS testing of this
* service. This does allow a process to bind to itself if it holds the proper
* permission. We do not consider this to be an issue given that the process can already
* access the service data since they are in the same process.
*/
private void checkPermissions() {
if (checkCallingPermission(NETWORK_SETTINGS) != PackageManager.PERMISSION_GRANTED
&& checkCallingPermission(NETWORK_SETUP_WIZARD)
!= PackageManager.PERMISSION_GRANTED) {
if (checkCallingOrSelfPermission(NETWORK_SETTINGS)
!= PackageManager.PERMISSION_GRANTED
&& checkCallingOrSelfPermission(NETWORK_SETUP_WIZARD)
!= PackageManager.PERMISSION_GRANTED) {
throw new SecurityException("Calling process must have NETWORK_SETTINGS or"
+ " NETWORK_SETUP_WIZARD permission");
}