Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log when job quota is reduced for buggy apps

Browse Source 
Count the times job scheduler artificially lowers quota for a job
because it considers the caller buggy due to excessive job timeouts.

The logic is refactored to allow simpler logging, but no other
functional change is intended.

Test: statsd_testdrive 528

Existing job tests:
Test: atest FrameworksMockingServicesTests:JobSchedulerServiceTest
Test: atest FrameworksMockingServicesTests:JobStatusTest

Bug: 291146667
Change-Id: I62654be0a0cdc713a17146c3ec612b37e8283b3e
Merged-In: I62654be0a0cdc713a17146c3ec612b37e8283b3e
This commit is contained in:
Suprabh Shukla
2023-07-13 18:20:02 -07:00
parent 5791ab0da3
commit 65a7257850
1 changed files with 26 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
apex/jobscheduler/service/java/com/android/server/job/controllers/JobStatus.java
View File

@@ -56,6 +56,7 @@ import com.android.internal.annotations.GuardedBy;
import com.android.internal.annotations.VisibleForTesting;
import com.android.internal.util.ArrayUtils;
import com.android.internal.util.FrameworkStatsLog;
import com.android.modules.expresslog.Counter;
import com.android.server.LocalServices;
import com.android.server.job.GrantedUriPermissions;
import com.android.server.job.JobSchedulerInternal;
@@ -161,6 +162,9 @@ public final class JobStatus {
/** If the job is going to be passed an unmetered network. */
private boolean mHasAccessToUnmetered;
/** If the effective bucket has been downgraded once due to being buggy. */
private boolean mIsDowngradedDueToBuggyApp;
/**
* The additional set of dynamic constraints that must be met if this is an expedited job that
* had a long enough run while the device was Dozing or in battery saver.
@@ -1173,18 +1177,32 @@ public final class JobStatus {
// like other ACTIVE apps.
return ACTIVE_INDEX;
}
final int bucketWithMediaExemption;
if (actualBucket != RESTRICTED_INDEX && actualBucket != NEVER_INDEX
&& mHasMediaBackupExemption) {
// Treat it as if it's at most WORKING_INDEX (lower index grants higher quota) since
// media backup jobs are important to the user, and the source package may not have
// been used directly in a while.
bucketWithMediaExemption = Math.min(WORKING_INDEX, actualBucket);
} else {
bucketWithMediaExemption = actualBucket;
}
// If the app is considered buggy, but hasn't yet been put in the RESTRICTED bucket
// (potentially because it's used frequently by the user), limit its effective bucket
// so that it doesn't get to run as much as a normal ACTIVE app.
final int highestBucket = isBuggy ? WORKING_INDEX : ACTIVE_INDEX;
if (actualBucket != RESTRICTED_INDEX && actualBucket != NEVER_INDEX
&& mHasMediaBackupExemption) {
// Treat it as if it's at least WORKING_INDEX since media backup jobs are important
// to the user, and the
// source package may not have been used directly in a while.
return Math.max(highestBucket, Math.min(WORKING_INDEX, actualBucket));
if (isBuggy && bucketWithMediaExemption < WORKING_INDEX) {
if (!mIsDowngradedDueToBuggyApp) {
// Safety check to avoid logging multiple times for the same job.
Counter.logIncrementWithUid(
"job_scheduler.value_job_quota_reduced_due_to_buggy_uid",
getTimeoutBlameUid());
mIsDowngradedDueToBuggyApp = true;
}
return WORKING_INDEX;
}
return Math.max(highestBucket, actualBucket);
return bucketWithMediaExemption;
}
/** Returns the real standby bucket of the job. */