Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix sound rate limiting issue" into oc-dr1-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2017-07-20 18:04:02 +00:00
committed by Android (Google) Code Review
parent 29119b6f5f 65b85cf3a2
commit 61913f178e
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
services/core/java/com/android/server/notification/NotificationManagerService.java
View File

@@ -3828,13 +3828,6 @@ public class NotificationManagerService extends SystemService {
return true;
}
// Suppressed for being too recently noisy
final String pkg = record.sbn.getPackageName();
if (mUsageStats.isAlertRateLimited(pkg)) {
Slog.e(TAG, "Muting recently noisy " + record.getKey());
return true;
}
// muted by listener
final String disableEffects = disableNotificationEffects(record);
if (disableEffects != null) {
@@ -3852,6 +3845,13 @@ public class NotificationManagerService extends SystemService {
return notification.suppressAlertingDueToGrouping();
}
// Suppressed for being too recently noisy
final String pkg = record.sbn.getPackageName();
if (mUsageStats.isAlertRateLimited(pkg)) {
Slog.e(TAG, "Muting recently noisy " + record.getKey());
return true;
}
return false;
}

10
services/tests/notification/src/com/android/server/notification/BuzzBeepBlinkTest.java
View File

@@ -830,6 +830,16 @@ public class BuzzBeepBlinkTest extends NotificationTestCase {
verify(mUsageStats, never()).isAlertRateLimited(any());
}
@Test
public void testPostingGroupSuppressedDoesNotAffectRateLimiting() throws Exception {
NotificationRecord summary = getBeepyNotificationRecord("a", GROUP_ALERT_CHILDREN);
summary.getNotification().flags |= Notification.FLAG_GROUP_SUMMARY;
mService.buzzBeepBlinkLocked(summary);
verify(mUsageStats, never()).isAlertRateLimited(any());
}
@Test
public void testCrossUserSoundMuted() throws Exception {
final Notification n = new Builder(getContext(), "test")