Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes a crash ColorScheme#toString

Browse Source 
Fixes an IndexOutOfBoundsException in stringForColor whenever the
value is between 0 and 15. Integer#toHexString does not zero pad.

Bug: 234413479
Test: atest ColorSchemeTest#testToString
Change-Id: I50f95ee8f2b1924bb1778b66ed39fa40685ef7e2
This commit is contained in:
Mark Renouf
2022-06-09 03:35:24 +00:00
parent 735ebc1f79
commit 5ecdfa1555
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/monet/src/com/android/systemui/monet/ColorScheme.kt
View File

@@ -435,7 +435,7 @@ class ColorScheme(
val h = "H${hct.hue.roundToInt().toString().padEnd(width)}"
val c = "C${hct.chroma.roundToInt().toString().padEnd(width)}"
val t = "T${CamUtils.lstarFromInt(color).roundToInt().toString().padEnd(width)}"
val hex = Integer.toHexString(color).replaceRange(0, 2, "").uppercase()
val hex = Integer.toHexString(color and 0xffffff).padStart(6, '0').uppercase()
return "$h$c$t = #$hex"
}

14
packages/SystemUI/tests/src/com/android/systemui/monet/ColorSchemeTest.java
View File

@@ -146,6 +146,20 @@ public class ColorSchemeTest extends SysuiTestCase {
Assert.assertTrue(cam.getChroma() <= 8.0);
}
@Test
@SuppressWarnings("ResultOfMethodCallIgnored")
public void testToString() {
new ColorScheme(Color.TRANSPARENT, false /* darkTheme */).toString();
new ColorScheme(Color.argb(0, 0, 0, 0xf), false /* darkTheme */).toString();
new ColorScheme(Color.argb(0xff, 0xff, 0, 0), false /* darkTheme */).toString();
new ColorScheme(0xFFFFFFFF, false /* darkTheme */).toString();
new ColorScheme(Color.TRANSPARENT, true /* darkTheme */).toString();
new ColorScheme(Color.argb(0, 0, 0, 0xf), true /* darkTheme */).toString();
new ColorScheme(0xFFFF0000, true /* darkTheme */).toString();
new ColorScheme(0xFFFFFFFF, true /* darkTheme */).toString();
}
/**
* Generate xml for SystemPaletteTest#testThemeStyles().
*/