Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Chipbar] Re-name the dimens to be chipbar instead of media_ttt.

Browse Source 
Bug: 245610654
Test: Triggered each of the media ttt chips and verified they still
appeared correctly

Change-Id: Ia2441b383c33ddbd182636f4bcfb36b67a4c77e7
This commit is contained in:
Caitlin Shkuratov
2023-03-08 16:01:52 +00:00
parent dccbda11b8
commit 5eb4f21fee
4 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
packages/SystemUI/res/drawable/media_ttt_chip_background.xml → packages/SystemUI/res/drawable/chipbar_background.xml
View File

0
packages/SystemUI/res/drawable/media_ttt_undo_background.xml → packages/SystemUI/res/drawable/chipbar_end_button_background.xml
View File

41
packages/SystemUI/res/layout/chipbar.xml
View File

@@ -29,8 +29,8 @@
android:orientation="horizontal"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:padding="@dimen/media_ttt_chip_outer_padding"
android:background="@drawable/media_ttt_chip_background"
android:padding="@dimen/chipbar_outer_padding"
android:background="@drawable/chipbar_background"
android:layout_marginTop="20dp"
android:layout_marginStart="@dimen/notification_side_paddings"
android:layout_marginEnd="@dimen/notification_side_paddings"
@@ -43,8 +43,8 @@
<com.android.internal.widget.CachingIconView
android:id="@+id/start_icon"
android:layout_width="@dimen/media_ttt_app_icon_size"
android:layout_height="@dimen/media_ttt_app_icon_size"
android:layout_width="@dimen/chipbar_start_icon_size"
android:layout_height="@dimen/chipbar_start_icon_size"
android:layout_marginEnd="12dp"
android:alpha="0.0"
/>
@@ -54,7 +54,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_weight="1"
android:textSize="@dimen/media_ttt_text_size"
android:textSize="@dimen/chipbar_text_size"
android:textColor="?android:attr/textColorPrimary"
android:alpha="0.0"
/>
@@ -62,9 +62,9 @@
<!-- At most one of [loading, failure_icon, undo] will be visible at a time. -->
<ImageView
android:id="@+id/loading"
android:layout_width="@dimen/media_ttt_status_icon_size"
android:layout_height="@dimen/media_ttt_status_icon_size"
android:layout_marginStart="@dimen/media_ttt_last_item_start_margin"
android:layout_width="@dimen/chipbar_end_icon_size"
android:layout_height="@dimen/chipbar_end_icon_size"
android:layout_marginStart="@dimen/chipbar_end_item_start_margin"
android:src="@drawable/ic_progress_activity"
android:tint="?androidprv:attr/colorAccentPrimaryVariant"
android:alpha="0.0"
@@ -72,29 +72,28 @@
<ImageView
android:id="@+id/error"
android:layout_width="@dimen/media_ttt_status_icon_size"
android:layout_height="@dimen/media_ttt_status_icon_size"
android:layout_marginStart="@dimen/media_ttt_last_item_start_margin"
android:layout_width="@dimen/chipbar_end_icon_size"
android:layout_height="@dimen/chipbar_end_icon_size"
android:layout_marginStart="@dimen/chipbar_end_item_start_margin"
android:src="@drawable/ic_warning"
android:tint="@color/GM2_red_500"
android:alpha="0.0"
/>
<!-- TODO(b/245610654): Re-name all the media-specific dimens to chipbar dimens instead. -->
<TextView
android:id="@+id/end_button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:textColor="?androidprv:attr/textColorOnAccent"
android:layout_marginStart="@dimen/media_ttt_last_item_start_margin"
android:textSize="@dimen/media_ttt_text_size"
android:paddingStart="@dimen/media_ttt_chip_outer_padding"
android:paddingEnd="@dimen/media_ttt_chip_outer_padding"
android:paddingTop="@dimen/media_ttt_undo_button_vertical_padding"
android:paddingBottom="@dimen/media_ttt_undo_button_vertical_padding"
android:layout_marginTop="@dimen/media_ttt_undo_button_vertical_negative_margin"
android:layout_marginBottom="@dimen/media_ttt_undo_button_vertical_negative_margin"
android:background="@drawable/media_ttt_undo_background"
android:layout_marginStart="@dimen/chipbar_end_item_start_margin"
android:textSize="@dimen/chipbar_text_size"
android:paddingStart="@dimen/chipbar_outer_padding"
android:paddingEnd="@dimen/chipbar_outer_padding"
android:paddingTop="@dimen/chipbar_end_button_vertical_padding"
android:paddingBottom="@dimen/chipbar_end_button_vertical_padding"
android:layout_marginTop="@dimen/chipbar_end_button_vertical_negative_margin"
android:layout_marginBottom="@dimen/chipbar_end_button_vertical_negative_margin"
android:background="@drawable/chipbar_end_button_background"
android:alpha="0.0"
/>

17
packages/SystemUI/res/values/dimens.xml
View File

@@ -1111,14 +1111,15 @@
<dimen name="qs_media_rec_album_title_bottom_margin">22dp</dimen>
<dimen name="qs_media_rec_album_subtitle_height">12dp</dimen>
<!-- Media tap-to-transfer chip for sender device -->
<dimen name="media_ttt_chip_outer_padding">16dp</dimen>
<dimen name="media_ttt_text_size">16sp</dimen>
<dimen name="media_ttt_app_icon_size">24dp</dimen>
<dimen name="media_ttt_status_icon_size">20dp</dimen>
<dimen name="media_ttt_undo_button_vertical_padding">8dp</dimen>
<dimen name="media_ttt_undo_button_vertical_negative_margin">-8dp</dimen>
<dimen name="media_ttt_last_item_start_margin">12dp</dimen>
<!-- Chipbar -->
<!-- (Used for media tap-to-transfer chip for sender device and active unlock) -->
<dimen name="chipbar_outer_padding">16dp</dimen>
<dimen name="chipbar_text_size">16sp</dimen>
<dimen name="chipbar_start_icon_size">24dp</dimen>
<dimen name="chipbar_end_icon_size">20dp</dimen>
<dimen name="chipbar_end_button_vertical_padding">8dp</dimen>
<dimen name="chipbar_end_button_vertical_negative_margin">-8dp</dimen>
<dimen name="chipbar_end_item_start_margin">12dp</dimen>
<!-- Media tap-to-transfer chip for receiver device -->
<dimen name="media_ttt_icon_size_receiver">112dp</dimen>