Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't store copies of notifications for logging

Browse Source 
We only need to retain the String representation
of the event

Test: manual
Fixes: 142823448
Change-Id: I907143e5a5f87c9a561e3d23cd365243c9901ee3
This commit is contained in:
Beverly
2019-10-17 10:27:08 -04:00
committed by Beverly Tai
parent 30f59237f2
commit 5db227d236
1 changed files with 10 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
packages/SystemUI/src/com/android/systemui/statusbar/notification/logging/NotifEvent.java
View File

@@ -27,12 +27,11 @@ import java.lang.annotation.RetentionPolicy;
/**
* An event related to notifications. {@link NotifLog} stores and prints these events for debugging
* and triaging purposes.
* and triaging purposes. We do not store a copy of the status bar notification nor ranking
* here to mitigate memory usage.
*/
public class NotifEvent extends RichEvent {
public static final int TOTAL_EVENT_TYPES = 11;
private final StatusBarNotification mSbn;
private final Ranking mRanking;
/**
* Creates a NotifEvent with an event type that matches with an index in the array
@@ -44,34 +43,20 @@ public class NotifEvent extends RichEvent {
public NotifEvent(int logLevel, int type, String reason, StatusBarNotification sbn,
Ranking ranking) {
super(logLevel, type, reason);
mMessage += getExtraInfo(sbn, ranking);
}
private String getExtraInfo(StatusBarNotification sbn, Ranking ranking) {
StringBuilder extraInfo = new StringBuilder();
if (sbn != null) {
mSbn = sbn.cloneLight();
} else {
mSbn = null;
extraInfo.append(" Sbn=");
extraInfo.append(sbn);
}
if (ranking != null) {
mRanking = new Ranking();
mRanking.populate(ranking);
} else {
mRanking = null;
}
mMessage += getExtraInfo();
}
private String getExtraInfo() {
StringBuilder extraInfo = new StringBuilder();
if (mSbn != null) {
extraInfo.append(" Sbn=");
extraInfo.append(mSbn);
}
if (mRanking != null) {
extraInfo.append(" Ranking=");
extraInfo.append(mRanking);
extraInfo.append(ranking);
}
return extraInfo.toString();
@@ -106,13 +91,6 @@ public class NotifEvent extends RichEvent {
return events;
}
/**
* @return a copy of the status bar notification that changed with this event
*/
public StatusBarNotification getSbn() {
return mSbn;
}
/**
* Builds a NotifEvent.
*/