Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix MemoryLeak warning in frameworks/base/services

Browse Source 
Fixed warning: Memory allocated by 'new' should be deallocated by
'delete', not free().

Bug: 31999593

Test: mmma framework/base/services, with WITH_TIDY and
WITH_STATIC_ANALYZER, the warning has gone.

Change-Id: Ib19fd2f210468b712ee72a4760d2abe8355c59e2
This commit is contained in:
Zhizhou Yang
2017-02-14 16:16:33 -08:00
parent 0bf608ee82
commit 5caf5fdc6f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/core/jni/com_android_server_location_ContextHubService.cpp
View File

@@ -511,7 +511,7 @@ int startLoadAppTxn(uint64_t appId, int hubHandle) {
if (!txnInfo || instanceId < 0) {
returnId(instanceId);
free(txnInfo);
delete txnInfo;
return -1;
}
@@ -524,7 +524,7 @@ int startLoadAppTxn(uint64_t appId, int hubHandle) {
if (db.txnManager.addTxn(CONTEXT_HUB_LOAD_APP, txnInfo) != 0) {
returnId(instanceId);
free(txnInfo);
delete txnInfo;
return -1;
}
@@ -541,7 +541,7 @@ int startUnloadAppTxn(jint appInstanceHandle) {
*txnData = appInstanceHandle;
if (db.txnManager.addTxn(CONTEXT_HUB_UNLOAD_APP, txnData) != 0) {
free(txnData);
delete txnData;
ALOGW("Cannot start transaction to unload app");
return -1;
}