Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix insert mode draws extra rectangle at the end of the first line

Browse Source 
Bug: 276784691
Test: manually tested
Change-Id: If0433c9bb3744d4bd0385c11b6d5c37d299af196
This commit is contained in:
Haoyu Zhang
2023-04-06 14:57:55 -07:00
parent 7b888dcc01
commit 5a7bf6e00a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/java/android/widget/Editor.java
View File

@@ -8095,12 +8095,14 @@ public class Editor {
private boolean mIsInsertModeActive;
private InsertModeTransformationMethod mInsertModeTransformationMethod;
private final Paint mHighlightPaint;
private final Path mHighlightPath;
InsertModeController(@NonNull TextView textView) {
mTextView = Objects.requireNonNull(textView);
mIsInsertModeActive = false;
mInsertModeTransformationMethod = null;
mHighlightPaint = new Paint();
mHighlightPath = new Path();
// The highlight color is supposed to be 12% of the color primary40. We can't
// directly access Material 3 theme. But because Material 3 sets the colorPrimary to
@@ -8168,10 +8170,8 @@ public class Editor {
((InsertModeTransformationMethod.TransformedText) transformedText);
final int highlightStart = insertModeTransformedText.getHighlightStart();
final int highlightEnd = insertModeTransformedText.getHighlightEnd();
final Layout.SelectionRectangleConsumer consumer =
(left, top, right, bottom, textSelectionLayout) ->
canvas.drawRect(left, top, right, bottom, mHighlightPaint);
layout.getSelection(highlightStart, highlightEnd, consumer);
layout.getSelectionPath(highlightStart, highlightEnd, mHighlightPath);
canvas.drawPath(mHighlightPath, mHighlightPaint);
}
}