Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NSSL touch logs should spam the ShadeLog buffer instead of the NotifHeadsUpLog buffer

Browse Source 
Fixes: 290924586
Test: dumpsysui NotifHeadsUpLog -- observe no touch logs
Test: dumpsysui ShadeLog -- observe touch logs
Change-Id: I87feeeea10ae5af297231798a8e25f194511a5d7
This commit is contained in:
Jeff DeCew
2023-07-12 10:58:37 -04:00
parent 24b72bdf59
commit 5a72d49718
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java
View File

@@ -3758,20 +3758,20 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable
case MotionEvent.ACTION_UP:
if (mStatusBarState != StatusBarState.KEYGUARD && mTouchIsClick &&
isBelowLastNotification(mInitialTouchX, mInitialTouchY)) {
debugLog("handleEmptySpaceClick: touch event propagated further");
debugShadeLog("handleEmptySpaceClick: touch event propagated further");
mOnEmptySpaceClickListener.onEmptySpaceClicked(mInitialTouchX, mInitialTouchY);
}
break;
default:
debugLog("handleEmptySpaceClick: MotionEvent ignored");
debugShadeLog("handleEmptySpaceClick: MotionEvent ignored");
}
}
private void debugLog(@CompileTimeConstant final String s) {
private void debugShadeLog(@CompileTimeConstant final String s) {
if (mLogger == null) {
return;
}
mLogger.d(s);
mLogger.logShadeDebugEvent(s);
}
private void logEmptySpaceClick(MotionEvent ev, boolean isTouchBelowLastNotification,

8
packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLogger.kt
View File

@@ -7,6 +7,7 @@ import com.android.systemui.log.core.LogLevel.INFO
import com.android.systemui.log.core.LogLevel.ERROR
import com.android.systemui.log.dagger.NotificationHeadsUpLog
import com.android.systemui.log.dagger.NotificationRenderLog
import com.android.systemui.log.dagger.ShadeLog
import com.android.systemui.statusbar.notification.collection.NotificationEntry
import com.android.systemui.statusbar.notification.logKey
import com.android.systemui.statusbar.notification.stack.NotificationStackScrollLayout.AnimationEvent.ANIMATION_TYPE_ADD
@@ -19,7 +20,8 @@ import javax.inject.Inject
class NotificationStackScrollLogger @Inject constructor(
@NotificationHeadsUpLog private val buffer: LogBuffer,
@NotificationRenderLog private val notificationRenderBuffer: LogBuffer
@NotificationRenderLog private val notificationRenderBuffer: LogBuffer,
@ShadeLog private val shadeLogBuffer: LogBuffer,
) {
fun hunAnimationSkipped(entry: NotificationEntry, reason: String) {
buffer.log(TAG, INFO, {
@@ -63,7 +65,7 @@ class NotificationStackScrollLogger @Inject constructor(
})
}
fun d(@CompileTimeConstant msg: String) = buffer.log(TAG, DEBUG, msg)
fun logShadeDebugEvent(@CompileTimeConstant msg: String) = shadeLogBuffer.log(TAG, DEBUG, msg)
fun logEmptySpaceClick(
isBelowLastNotification: Boolean,
@@ -71,7 +73,7 @@ class NotificationStackScrollLogger @Inject constructor(
touchIsClick: Boolean,
motionEventDesc: String
) {
buffer.log(TAG, DEBUG, {
shadeLogBuffer.log(TAG, DEBUG, {
int1 = statusBarState
bool1 = touchIsClick
bool2 = isBelowLastNotification