Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bail out after kMaxColorFormatSupported calls to OMX_GetParameter().

Browse Source 
Avoid infinite loop in querying omx component about the supported color format.

Change-Id: I4997efd36462c792a6d8b5e04c79a80966a559fe
related-to-bug: 5466057
This commit is contained in:
James Dong
2011-10-18 16:21:52 -07:00
parent a25a997597
commit 5a37afa87c
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
media/libstagefright/OMXCodec.cpp
View File

@@ -52,6 +52,13 @@ namespace android {
// buffers after 3 seconds.
const static int64_t kBufferFilledEventTimeOutNs = 3000000000LL;
// OMX Spec defines less than 50 color formats. If the query for
// color format is executed for more than kMaxColorFormatSupported,
// the query will fail to avoid looping forever.
// 1000 is more than enough for us to tell whether the omx
// component in question is buggy or not.
const static uint32_t kMaxColorFormatSupported = 1000;
struct CodecInfo {
const char *mime;
const char *codec;
@@ -818,6 +825,11 @@ status_t OMXCodec::setVideoPortFormatType(
}
++index;
if (index >= kMaxColorFormatSupported) {
CODEC_LOGE("color format %d or compression format %d is not supported",
colorFormat, compressionFormat);
return UNKNOWN_ERROR;
}
}
if (!found) {
@@ -901,22 +913,19 @@ status_t OMXCodec::isColorFormatSupported(
// the incremented index (bug 2897413).
CHECK_EQ(index, portFormat.nIndex);
if (portFormat.eColorFormat == colorFormat) {
LOGV("Found supported color format: %d", portFormat.eColorFormat);
CODEC_LOGV("Found supported color format: %d", portFormat.eColorFormat);
return OK; // colorFormat is supported!
}
++index;
portFormat.nIndex = index;
// OMX Spec defines less than 50 color formats
// 1000 is more than enough for us to tell whether the omx
// component in question is buggy or not.
if (index >= 1000) {
LOGE("More than %ld color formats are supported???", index);
if (index >= kMaxColorFormatSupported) {
CODEC_LOGE("More than %ld color formats are supported???", index);
break;
}
}
LOGE("color format %d is not supported", colorFormat);
CODEC_LOGE("color format %d is not supported", colorFormat);
return UNKNOWN_ERROR;
}