Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "CEC: Prevent overwriting volume control Settings" into rvc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-06-17 09:13:15 +00:00
committed by Android (Google) Code Review
parent 4c6f3ff3e2 6896a53257
commit 58fd58dea7
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/core/java/com/android/server/hdmi/HdmiControlService.java
View File

@@ -3142,7 +3142,7 @@ public class HdmiControlService extends SystemService {
return;
}
setHdmiCecVolumeControlEnabled(false);
mHdmiCecVolumeControlEnabled = false;
// Call the vendor handler before the service is disabled.
invokeVendorCommandListenersOnControlStateChanged(false,
HdmiControlManager.CONTROL_STATE_CHANGED_REASON_SETTING);

13
services/tests/servicestests/src/com/android/server/hdmi/HdmiControlServiceTest.java
View File

@@ -263,6 +263,19 @@ public class HdmiControlServiceTest {
assertThat(mHdmiControlService.isHdmiCecVolumeControlEnabled()).isTrue();
}
@Test
public void disableAndReenableCec_volumeControlReturnsToOriginalValue() {
boolean volumeControlEnabled = true;
mHdmiControlService.setHdmiCecVolumeControlEnabled(volumeControlEnabled);
mHdmiControlService.setControlEnabled(false);
assertThat(mHdmiControlService.isHdmiCecVolumeControlEnabled()).isFalse();
mHdmiControlService.setControlEnabled(true);
assertThat(mHdmiControlService.isHdmiCecVolumeControlEnabled()).isEqualTo(
volumeControlEnabled);
}
@Test
public void addHdmiCecVolumeControlFeatureListener_emitsCurrentState_enabled() {
mHdmiControlService.setHdmiCecVolumeControlEnabled(true);