Merge "bit: avoid calling strdup(NULL)"

2022-02-24 03:27:26 +00:00
parent 9e70a83ea0 d53c27404d
commit 589f3e4871
1 changed files with 3 additions and 2 deletions
--- a/tools/bit/command.cpp
+++ b/tools/bit/command.cpp
@@ -192,10 +192,11 @@ exec_with_path_search(const char* prog, char const* const* argv, char const* con
    if (strchr(prog, '/') != NULL) {
        return execve(prog, (char*const*)argv, (char*const*)envp);
    } else {
-        char* pathEnv = strdup(getenv("PATH"));
-        if (pathEnv == NULL) {
+        const char* pathEnvRaw = getenv("PATH");
+        if (pathEnvRaw == NULL) {
            return 1;
        }
+        char* pathEnv = strdup(pathEnvRaw);
        char* dir = pathEnv;
        while (dir) {
            char* next = strchr(dir, ':');