Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change AudioManger getMode() binder call to addOnModeChangedListener()

Browse Source 
- Remove binder call from running each time with clicking on volume up
and down keys. Replace it with listener instead.

Bug: 240705522
Test: Manual using Signal App / Youtube and Sample MediaRouter App.
Change-Id: I842133770a583217940ebc929d8d929f4cd27a51
This commit is contained in:
Bishoy Gendy
2023-03-03 10:08:34 +00:00
parent 188ab32778
commit 57ff593ed5
2 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/java/android/view/Window.java
View File

@@ -823,6 +823,11 @@ public abstract class Window {
/** @hide */
public final void destroy() {
mDestroyed = true;
onDestroy();
}
/** @hide */
protected void onDestroy() {
}
/** @hide */

35
core/java/com/android/internal/policy/PhoneWindow.java
View File

@@ -295,6 +295,7 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
private boolean mClosingActionMenu;
private int mVolumeControlStreamType = AudioManager.USE_DEFAULT_STREAM_TYPE;
private int mAudioMode = AudioManager.MODE_NORMAL;
private MediaController mMediaController;
private AudioManager mAudioManager;
@@ -317,6 +318,8 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
}
};
private AudioManager.OnModeChangedListener mOnModeChangedListener;
private Transition mEnterTransition = null;
private Transition mReturnTransition = USE_DEFAULT_TRANSITION;
private Transition mExitTransition = null;
@@ -1952,7 +1955,7 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
case KeyEvent.KEYCODE_VOLUME_MUTE: {
// If we have a session and no active phone call send it the volume command,
// otherwise use the suggested stream.
if (mMediaController != null && !isActivePhoneCallKnown()) {
if (mMediaController != null && !isActivePhoneCallOngoing()) {
getMediaSessionManager().dispatchVolumeKeyEventToSessionAsSystemService(event,
mMediaController.getSessionToken());
} else {
@@ -2003,16 +2006,9 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
return false;
}
private boolean isActivePhoneCallKnown() {
boolean isActivePhoneCallKnown = false;
AudioManager audioManager =
(AudioManager) getContext().getSystemService(Context.AUDIO_SERVICE);
int audioManagerMode = audioManager.getMode();
if (audioManagerMode == AudioManager.MODE_IN_CALL
|| audioManagerMode == AudioManager.MODE_IN_COMMUNICATION) {
isActivePhoneCallKnown = true;
}
return isActivePhoneCallKnown;
private boolean isActivePhoneCallOngoing() {
return mAudioMode == AudioManager.MODE_IN_CALL
|| mAudioMode == AudioManager.MODE_IN_COMMUNICATION;
}
private KeyguardManager getKeyguardManager() {
@@ -2338,6 +2334,14 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
}
}
@Override
protected void onDestroy() {
if (mOnModeChangedListener != null) {
getAudioManager().removeOnModeChangedListener(mOnModeChangedListener);
mOnModeChangedListener = null;
}
}
private class PanelMenuPresenterCallback implements MenuPresenter.Callback {
@Override
public void onCloseMenu(MenuBuilder menu, boolean allMenusAreClosing) {
@@ -3220,6 +3224,15 @@ public class PhoneWindow extends Window implements MenuBuilder.Callback {
@Override
public void setMediaController(MediaController controller) {
mMediaController = controller;
if (controller != null && mOnModeChangedListener == null) {
mAudioMode = getAudioManager().getMode();
mOnModeChangedListener = mode -> mAudioMode = mode;
getAudioManager().addOnModeChangedListener(getContext().getMainExecutor(),
mOnModeChangedListener);
} else if (mOnModeChangedListener != null) {
getAudioManager().removeOnModeChangedListener(mOnModeChangedListener);
mOnModeChangedListener = null;
}
}
@Override