Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PIP: Always enable rounded corners

Browse Source 
Bug: 187922869

Previously, we turned on rounded corners with a sysprop in
bf309e63d4. Now that a bug in rendering
them in landscape has been fixed, remove the sysprop and always use
the rounded corners radius specified in the xml file.

Change-Id: Ib0f61bbcbee6ead82beec2b149b0892836492b78
This commit is contained in:
Leon Scroggins III
2021-03-15 15:54:41 -04:00
parent 3d18b83a20
commit 4dda15cd27
3 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipSurfaceTransactionHelper.java
View File

@@ -20,7 +20,6 @@ import android.content.Context;
import android.graphics.Matrix;
import android.graphics.Rect;
import android.graphics.RectF;
import android.os.SystemProperties;
import android.view.SurfaceControl;
import com.android.wm.shell.R;
@@ -44,10 +43,7 @@ public class PipSurfaceTransactionHelper {
* @param context the current context
*/
public void onDensityOrFontScaleChanged(Context context) {
final boolean enableCornerRadius =
SystemProperties.getBoolean("debug.sf.enable_hole_punch_pip", false);
mCornerRadius = enableCornerRadius
? context.getResources().getDimensionPixelSize(R.dimen.pip_corner_radius) : 0;
mCornerRadius = context.getResources().getDimensionPixelSize(R.dimen.pip_corner_radius);
}
/**

6
libs/WindowManager/Shell/src/com/android/wm/shell/pip/phone/PipController.java
View File

@@ -535,10 +535,8 @@ public class PipController implements PipTransitionController.PipTransitionCallb
private void onPipCornerRadiusChanged() {
if (mPinnedStackAnimationRecentsCallback != null) {
final boolean enableCornerRadius =
SystemProperties.getBoolean("debug.sf.enable_hole_punch_pip", false);
final int cornerRadius = enableCornerRadius
? mContext.getResources().getDimensionPixelSize(R.dimen.pip_corner_radius) : 0;
final int cornerRadius =
mContext.getResources().getDimensionPixelSize(R.dimen.pip_corner_radius);
try {
mPinnedStackAnimationRecentsCallback.onPipCornerRadiusChanged(cornerRadius);
} catch (RemoteException e) {

7
libs/WindowManager/Shell/src/com/android/wm/shell/pip/phone/PipMenuView.java
View File

@@ -45,7 +45,6 @@ import android.graphics.drawable.Drawable;
import android.net.Uri;
import android.os.Bundle;
import android.os.Handler;
import android.os.SystemProperties;
import android.os.UserHandle;
import android.util.Log;
import android.util.Pair;
@@ -152,11 +151,7 @@ public class PipMenuView extends FrameLayout {
mAccessibilityManager = context.getSystemService(AccessibilityManager.class);
inflate(context, R.layout.pip_menu, this);
final boolean enableCornerRadius =
SystemProperties.getBoolean("debug.sf.enable_hole_punch_pip", false);
mBackgroundDrawable = enableCornerRadius
? mContext.getDrawable(R.drawable.pip_menu_background)
: new ColorDrawable(Color.BLACK);
mBackgroundDrawable = mContext.getDrawable(R.drawable.pip_menu_background);
mBackgroundDrawable.setAlpha(0);
mViewRoot = findViewById(R.id.background);
mViewRoot.setBackground(mBackgroundDrawable);