Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the redundant check.

Browse Source 
The max package name length restriction is already applied when
creating session. Removing the redundant check to avoid bumping
SessionParams.MAX_PACKAGE_NAME_LENGTH.

Bug: 236687884
Test: atest CtsPackageInstallTestCases
Change-Id: I79954b3d73bbfbb8d5b64329d86f5ff79a874d60
This commit is contained in:
Jackal Guo
2022-11-24 15:04:21 +08:00
parent c6918cbc67
commit 4d44021acc
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/PackageInstaller/src/com/android/packageinstaller/InstallStart.java
View File

@@ -28,7 +28,6 @@ import android.content.Intent;
import android.content.pm.ApplicationInfo;
import android.content.pm.PackageInfo;
import android.content.pm.PackageInstaller;
import android.content.pm.PackageInstaller.SessionParams;
import android.content.pm.PackageManager;
import android.content.pm.PackageManager.NameNotFoundException;
import android.content.pm.ProviderInfo;
@@ -104,10 +103,9 @@ public class InstallStart extends Activity {
Intent.EXTRA_INSTALLER_PACKAGE_NAME);
if (installerPackageNameFromIntent != null) {
final String callingPkgName = getLaunchedFromPackage();
if (installerPackageNameFromIntent.length() >= SessionParams.MAX_PACKAGE_NAME_LENGTH
|| (!TextUtils.equals(installerPackageNameFromIntent, callingPkgName)
if (!TextUtils.equals(installerPackageNameFromIntent, callingPkgName)
&& mPackageManager.checkPermission(Manifest.permission.INSTALL_PACKAGES,
callingPkgName) != PackageManager.PERMISSION_GRANTED)) {
callingPkgName) != PackageManager.PERMISSION_GRANTED) {
Log.e(LOG_TAG, "The given installer package name " + installerPackageNameFromIntent
+ " is invalid. Remove it.");
EventLog.writeEvent(0x534e4554, "236687884", getLaunchedFromUid(),